Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-12318] Adjustments for HxP Attach-File widget #8425

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

DudaRobert
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • [] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

'uploadWidget' string present in FormModel class in adf doesn't allow for extensions in hxp

What is the new behaviour?

  • added public options?: UploadWidgetContentLinkModelOptions as optional parameter in UploadWidgetContentLinkModel constructor,
  • added formDataRefreshed.next(new FormEvent(this.form)) in formContentClicked subscription in FormCloudComponent constructor.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@BSekula BSekula force-pushed the dev-rduda-hxp-workspace-attach-file-widget branch from f36a0ab to f81a687 Compare April 3, 2023 05:55
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DudaRobert DudaRobert merged commit 2bd72f7 into develop Apr 3, 2023
33 checks passed
@DudaRobert DudaRobert deleted the dev-rduda-hxp-workspace-attach-file-widget branch April 3, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants