Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAE-12501] move auth in ADF #8689

Merged
merged 88 commits into from
Nov 6, 2023
Merged

[AAE-12501] move auth in ADF #8689

merged 88 commits into from
Nov 6, 2023

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Jun 21, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
move auth in ADF

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

popovicsandras
popovicsandras approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@popovicsandras popovicsandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial approval (without thorough review yet) to let the CI kick in

@alep85 alep85 force-pushed the dev-eromano-AAE-12501-2 branch 6 times, most recently from c3c4ca5 to 207e6af Compare July 4, 2023 13:24
@alep85 alep85 force-pushed the dev-eromano-AAE-12501-2 branch 2 times, most recently from c13c748 to a02610b Compare July 10, 2023 16:22
@alep85 alep85 force-pushed the dev-eromano-AAE-12501-2 branch 2 times, most recently from 8c6b701 to efc5af7 Compare July 18, 2023 16:41
@alep85 alep85 mentioned this pull request Jul 21, 2023
Merged
@alep85
Copy link
Contributor

alep85 commented Jul 21, 2023 •
edited

@popovicsandras @eromano when all the e2es will be green, we have to revert this commit to re-enable all the unit tests that are temporary skipped

@eromano eromano force-pushed the dev-eromano-AAE-12501-2 branch 4 times, most recently from 1a35de0 to b0d44da Compare July 29, 2023 08:02
@eromano eromano force-pushed the dev-eromano-AAE-12501-2 branch 3 times, most recently from e4430c3 to 1dae430 Compare August 8, 2023 19:28
@alep85 alep85 force-pushed the dev-eromano-AAE-12501-2 branch 2 times, most recently from 01ae04a to 69c6a14 Compare August 14, 2023 14:50
eromano and others added 24 commits November 3, 2023 14:52
@eromano @alep85
fix rebase
81d5c9f
@alep85
[AAE-12502] Restore isKerberosEnabled into authentication service
4ad766f
@eromano @alep85
subject onLogin
8913599
@eromano @alep85
fix unit
acc12ee
@alep85
Fix lint issue
2bec9cf
@eromano @alep85
fix
dfedf18
@alep85
Update error message
12fe0c4
@alep85
Revert change did by https://github.com/Alfresco/alfresco-ng2-compone…
1791738 
…nts/pull/8689/commits/b79c5d37d69b2d76b33e5561eab2bf5b80c81b9e\#diff-ad85723e21276e05e577bab652c6ab0d243bd0ad54d4cc70ef6e60dc5e635c33L38
@alep85
Refresh the browser to wait for the user to click process cloud page
0342d9f
@alep85
Remove e2e, the application list is already tested by the app-list-cl…
cba9369 
…oud.component.spec.ts https://github.com/Alfresco/alfresco-ng2-components/blob/dev-eromano-AAE-12501-2/lib/process-services-cloud/src/lib/app/components/app-list-cloud.component.spec.ts\#L147
@alep85
[12502] Add getUsername method to the AuthenticationService
8b350c6
@alep85
[12501] restore mutlipart/form-data header needed by angular http-cli…
774f5a6 
…ent to to fix 415 unsupported media type
@alep85
Revert "[12501] restore mutlipart/form-data header needed by angular …
b1ba61f 
…http-client to to fix 415 unsupported media type"

This reverts commit d8c584b.
@alep85
[12501] fix unsupported upload file on admin-apa, append json content…
133f2b9 
… type only calling alfresco api
@alep85
[12501] fix unsupported upload file on admin-apa
0cf3725 
[12501] fix unsupported upload file on admin-apa
@alep85
Revert "[12501] fix unsupported upload file on admin-apa"
a70c80d 
This reverts commit 53cda21.
@alep85
Improve getHeaders
1d4f1d3
@alep85
Revert change
d58c622
@alep85
Set application/json content type if request body is not a FormData
0ccd0e4
@alep85
Logout by the authenticationService
62d3201
@alep85
Update returned error message
5a21a62
@alep85
Fix lint issues after rebasing
8ecff47
@alep85
[12502] Add basic template with data-automation-ad selector to check …
2c08a18 
…when is attached to the Dom
@alep85
Fix issues after rebase
f618a21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
5.2% 5.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@alep85
Copy link
Contributor

alep85 commented Nov 3, 2023

DenysVuika commented (#8689 (comment))
Is it possible remove any demo shell interaction from the PR?
@DenysVuika The changes to the demoshell are needed to work with the auth changes

@alep85 alep85 merged commit 08da9ae into develop Nov 6, 2023
35 of 36 checks passed
@alep85 alep85 deleted the dev-eromano-AAE-12501-2 branch November 6, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popovicsandras popovicsandras popovicsandras approved these changes

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eromano @alep85 @DenysVuika @popovicsandras @arditdomi