Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-5703] Comment List code and styles cleanup #8787

Merged
merged 23 commits into from
Jul 31, 2023
Merged

[ACS-5703] Comment List code and styles cleanup #8787

merged 23 commits into from
Jul 31, 2023

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Jul 25, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • cleanup the code and styles for the Comment List
  • remove technical debts
  • (security) remove unsafe "innerHTML" binding, remove the need for custom sanitize due to Angular protections
  • drop selection animations and selected item (the component never had any selection actions besides storing the selection internally, can be re-introduced in the future once any actions are supported like editing, deletion, etc)
  • move "multiline" test from e2e to unit

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-5703

@DenysVuika DenysVuika changed the title Comment List code and styles cleanup [ACS-5703] Comment List code and styles cleanup Jul 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
27.2% 27.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@DenysVuika DenysVuika merged commit 3f3e830 into develop Jul 31, 2023
33 of 34 checks passed
@DenysVuika DenysVuika deleted the comments-fixes branch July 31, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
A/N BDU security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DenysVuika @AleksanderSklorz