[AAE-16995] Code refactor of LocationCellComponent #9033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktord2000
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
tomgny
reviewed
Oct 30, 2023
lib/core/src/lib/datatable/components/datatable-cell/datatable-cell.component.ts
Show resolved
Hide resolved
tomgny
reviewed
Oct 30, 2023
lib/core/src/lib/datatable/components/datatable-cell/datatable-cell.component.ts
Outdated
Show resolved
Hide resolved
tomgny
reviewed
Oct 30, 2023
lib/core/src/lib/datatable/components/location-cell/location-cell.component.ts
Outdated
Show resolved
Hide resolved
tomgny
approved these changes
Oct 31, 2023
wiktord2000
force-pushed
the
AAE-16995-handle-location-type
branch
from
f73e0c9
to
aa3d1b4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-16995
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
We were trying to use this type to handle simple links but at some point we realized that it isn't the best place and we are going to compose another type in the future. But because I spent some time here I took this opportunity and made a small code refactor.