[ACS-5600] AlfrescoViewerComponent shows the original mimetype #9095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yasa-Nataliya
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
arohilaGL
reviewed
Nov 17, 2023
lib/content-services/src/lib/viewer/components/alfresco-viewer.component.html
Outdated
Show resolved
Hide resolved
arohilaGL
reviewed
Nov 17, 2023
arohilaGL
reviewed
Nov 17, 2023
| }; | ||
|
|
||
| component.originalMimeType = nodeData.content.mimeType; | ||
| expect(component.originalMimeType).toEqual(nodeData.content.mimeType); |
There was a problem hiding this comment.
This unit test is setting one thing and then expecting the same thing which was set in previous test.
There was a problem hiding this comment.
I have modified the test cases
arohilaGL
reviewed
Nov 17, 2023
arohilaGL
reviewed
Nov 17, 2023
|
functionality working as expected. |
Yasa-Nataliya
force-pushed
the
ACS-5600
branch
from
136be23
to
0efc094
Compare
Yasa-Nataliya
force-pushed
the
ACS-5600
branch
from
b66d714
to
c6fca56
Compare
lib/content-services/src/lib/viewer/components/alfresco-viewer.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/viewer/components/alfresco-viewer.component.spec.ts
Outdated
Show resolved
Hide resolved
Yasa-Nataliya
force-pushed
the
ACS-5600
branch
from
9310bb1
to
2e77347
Compare
lib/content-services/src/lib/viewer/components/alfresco-viewer.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/viewer/components/alfresco-viewer.component.spec.ts
Outdated
Show resolved
Hide resolved
AleksanderSklorz
approved these changes
Nov 23, 2023
Yasa-Nataliya
force-pushed
the
ACS-5600
branch
3 times, most recently
from
be3a063
to
f4211fc
Compare
Yasa-Nataliya
force-pushed
the
ACS-5600
branch
from
3702d58
to
5712e39
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
arohilaGL
approved these changes
Nov 30, 2023
rbahirsheth
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
The new viewer shows a PDF icon in the toolbar for documents having a PDF rendition (eg: DOCX, ODT, etc).
What is the new behaviour?
The new viewer shows the mimetype of the document and not the mimetype of the rendition.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/ACS-5600