[ACS-6812] Add new chip only when input value is valid #9358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalKinas
requested review from
nikita-web-ua,
swapnil-verma-gl,
AleksanderSklorz and
dominikiwanekhyland
MichalKinas
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
Outdated
Show resolved
Hide resolved
nikita-web-ua
approved these changes
Feb 19, 2024
AleksanderSklorz
approved these changes
Feb 19, 2024
DenysVuika
approved these changes
Feb 19, 2024
swapnil-verma-gl
approved these changes
Feb 20, 2024
|
MichalKinas
deleted the
bugfix/mkinas-ACS-6812-multivalue-number-in-content-metadata-card-is-not-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Decimal pipe is not able to handle arrays and new chips are added regardless applied validators which leads to exception being thrown.
What is the new behaviour?
Decimal pipe now correctly handles arrays, new chips are added only when input value passes the validation. Closes #8919 https://alfresco.atlassian.net/browse/ACS-6812
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: