Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6150] Add category selector dialog #9423

Merged
merged 8 commits into from
Mar 20, 2024

Conversation

nikita-web-ua
Copy link
Contributor

@nikita-web-ua nikita-web-ua commented Mar 12, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

Folder rules 'Link category' action has a text input that requires the user to enter the category ID manually, which is inconvenient. With this dialog you could select it from a list.

What is the new behaviour?

Category selector dialog was added to select one or multiple categories.
adf-category-selector-dialog

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-6150

@nikita-web-ua nikita-web-ua force-pushed the feature/ACS-6150-add-category-selector-dialog branch from 070cb47 to 651bd34 Compare March 13, 2024 11:11
Copy link
Contributor

@MichalKinas MichalKinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall PR looks good to me, I only wonder should we change the background with the list of categories to plain white for the dialog?

@nikita-web-ua
Copy link
Contributor Author

Overall PR looks good to me, I only wonder should we change the background with the list of categories to plain white for the dialog?

It is white:) In the example screenshot there is single selection mode and a category already selected, so the rest of the list is disabled.

@MichalKinas
Copy link
Contributor

Overall PR looks good to me, I only wonder should we change the background with the list of categories to plain white for the dialog?

It is white:) In the example screenshot there is single selection mode and a category already selected, so the rest of the list is disabled.

Ah okay, thanks for the explanation, all good then :)

@AleksanderSklorz
Copy link
Contributor

AleksanderSklorz commented Mar 13, 2024

Overall PR looks good to me, I only wonder should we change the background with the list of categories to plain white for the dialog?

Yeah @MichalKinas I had the same doubts and I added the same comment here: #9423 (comment)

I can see that even Tags have actually that gray background:
image

but in initial design when we were implementing that there was not gray background if I remember properly, see attached designs and Akash's video after verification in comments in that task:
https://alfresco.atlassian.net/browse/ACS-4118

@nikita-web-ua nikita-web-ua force-pushed the feature/ACS-6150-add-category-selector-dialog branch from 651bd34 to 3a18fbf Compare March 13, 2024 21:30
@nikita-web-ua nikita-web-ua force-pushed the feature/ACS-6150-add-category-selector-dialog branch from bee3c92 to 0c0f04c Compare March 15, 2024 08:15
@nikita-web-ua nikita-web-ua force-pushed the feature/ACS-6150-add-category-selector-dialog branch from 0c0f04c to c34f77c Compare March 20, 2024 07:23
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nikita-web-ua nikita-web-ua merged commit c642d0e into develop Mar 20, 2024
33 checks passed
@nikita-web-ua nikita-web-ua deleted the feature/ACS-6150-add-category-selector-dialog branch March 20, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants