HXCS-3381 fix date widget #9482
Conversation
|
Adriano Costa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| @@ -15,9 +15,16 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| import { format, parse, parseISO, isValid, isBefore, isAfter, lightFormat } from 'date-fns'; | |||
| import { format, parse, parseISO, isValid, isBefore, isAfter } from 'date-fns'; | |||
There was a problem hiding this comment.
lightFormat doesn't return the desired output when dealing with -XX:XXGMT timezones (eg: USA)
| @@ -203,18 +210,19 @@ export class DateFnsUtils { | |||
| return new Date(date.getUTCFullYear(), date.getUTCMonth(), date.getUTCDate(), date.getUTCHours(), date.getUTCMinutes(), date.getUTCSeconds()); | |||
| } | |||
|
|
|||
| static forceLocal(date: string | Date): Date { | |||
| if (typeof date === 'string'){ | |||
| static forceLocal(date: Date | string): Date { | |||
There was a problem hiding this comment.
forceLocal and forceUtc are meant to display the same date over different timezone.
So, giving a UTC date , the output might be a different Date. But since that date is localized automatically by the browser, the text displayed will be the same.
Eg: 03-24-1983T00:00:00Z localized to USA timezone is 03-23-1983T16:00:00 (notice the absence of Z, and different day and hours values). Instead forceUtc/forceLocal will convert the date to 03-24-1983T00:00:00, different value but same text when displayed
|
I have tested it in the Card View of ADF Demo App. I believe there are some other places to check I'm not aware of |
wideLandscape
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
Is it possible to simulate different timezones in the tests? the main issue here is that tests can be green in some tz and fail in others. |
| maybe here there are some ideas |
wideLandscape
force-pushed
the
fix/HXCS-3381-fix-date-widget
branch
from
0500b8f
to
bede4ab
Compare
| '09-02-9999 09:10 AM', | ||
| 'dd-MM-yyyy hh:mm aa' | ||
| ); | ||
| const parsed = DateFnsUtils.parseDate('09-02-9999 09:10 AM', 'dd-MM-yyyy hh:mm aa'); |
There was a problem hiding this comment.
all these format changes has been done automatically by linter when I did the commit
| it('should convert UTC dates to have the same day, month, year displayed in different timezone', () => { | ||
| const dateUTC = new Date('Wed Jan 01 2020 00:00:00 GMT+0000'); | ||
| const dateUSA = new Date('Tue Dec 31 2019 16:00:00 GMT-0800'); | ||
| const dateJapan = new Date('Wed Jan 01 2020 09:00:00 GMT+0900'); |
There was a problem hiding this comment.
Same instant in different timezones
|
|
@wideLandscape can you click the CLA button please to make the CI/CD happy |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/HXCS-3381
What is the new behaviour?
https://hyland.atlassian.net/browse/HXCS-3381
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
To change the timezone in Chrome open the inspector and click the three dots icon on the bottom panel, then select Sensors from the menu