Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: cleanup await expect from protractor tests #9630

Merged
merged 16 commits into from
Apr 30, 2024

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Apr 29, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

the @typescript-eslint/await-thenable prevents modified e2e files to be checked in unless all the expect await errors are fixed

What is the new behaviour?

  • cleanup old protractor tests to respect the @typescript-eslint/await-thenable eslint rule
  • fix errors with double quotes in strings (e2e)
  • fix code formatting in various old e2e files
  • fix missing documentation tags in e2e utility functions

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Contributor

@DaryaBalvanovich DaryaBalvanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor 🙂

lib/testing/.eslintrc.json Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@DenysVuika DenysVuika merged commit f401b8c into develop Apr 30, 2024
30 of 33 checks passed
@DenysVuika DenysVuika deleted the fix-await-thennable-eslint branch April 30, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants