Solr Allinone: The security-constraints removal keeps adding after restarts.

[loftux]

In the solr/pom.xml in the allinone archetype a replacement is made to add comment characters to remove security in web.xml. This is done on each restart, but since the file exist with this replacement it keeps adding upp so you get something like

    <!-- <!-- <security-constraint>

and comment within comment is not valid xml
The fix is to remove any previous added commenting, and than replace again.

                <configuration>
                    <ignoreErrors>true</ignoreErrors>
                    <file>${alfresco.solr.war.overlay}/WEB-INF/web.xml</file>
                    <replacements>
                        <replacement>
                            <token><![CDATA[<!-- <security-constraint>]]></token>
                            <value><![CDATA[<security-constraint>]]></value>
                        </replacement>
                        <replacement>
                            <token><![CDATA[</security-role> -->]]></token>
                            <value><![CDATA[</security-role>]]></value>
                        </replacement>
                        <replacement>
                            <token><![CDATA[<security-constraint>]]></token>
                            <value><![CDATA[<!-- <security-constraint>]]></value>
                        </replacement>
                        <replacement>
                            <token><![CDATA[</security-role>]]></token>
                            <value><![CDATA[</security-role> -->]]></value>
                        </replacement>
                    </replacements>
                </configuration>

Honorable mention to bhagyas for the fix!