Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven keystorefile,keystorePass, truststoreFile,truststorePass properties are not passed through #239

Closed
hagak opened this issue Dec 3, 2014 · 6 comments
Assignees
Milestone

Comments

@hagak
Copy link

hagak commented Dec 3, 2014

When trying to configure the keystore and truststore with an AMP build the properties do not seemed to be passed through to the tomcat plugin from the parent SDK plugin.

Note maven.tomcat.port does seem to work as expected however the others do not.
http://tomcat.apache.org/maven-plugin-2.2/tomcat7-maven-plugin/run-mojo.html

@mindthegab mindthegab added this to the 2.1.0 milestone Dec 19, 2014
@ohej ohej modified the milestones: 2.1.1, 2.1.0 Jun 8, 2015
@ohej
Copy link
Contributor

ohej commented Jun 8, 2015

Could you give a bit more info on your setup? Are you using all-in-one or the AMP archetype?

With 2.1.0 I have no issue overriding maven.tomcat.port, so I'm not sure what is going on. Are you overriding them all via command line or the pom?

We are working on adding a section to the documentation of 2.1.0 on how to configure SSL, let me know if you want to review it.

@hagak
Copy link
Author

hagak commented Jun 8, 2015

We are using the AMP archetype. We have no issues setting maven.tomcat.port via the POM. We are having issues setting other tomcat configs via the POM such as the keystore, keystorePass, truststoreFile, truststorePass.

I would like to review that documentation. Thank you

Jeffrey Gordon
Progeny Systems
Software Engineer
jgordon@progeny.netmailto:jgordon@progeny.net
703.368.6107 x493

From: Ole Hejlskov [mailto:notifications@github.com]
Sent: Monday, June 08, 2015 03:32
To: Alfresco/alfresco-sdk
Cc: Gordon, Jeffrey
Subject: (nwl) Re: [alfresco-sdk] maven keystorefile,keystorePass, truststoreFile,truststorePass properties are not passed through (#239)

Could you give a bit more info on your setup? Are you using all-in-one or the AMP archetype?

With 2.1.0 I have no issue overriding maven.tomcat.port, so I'm not sure what is going on. Are you overriding them all via command line or the pom?

We are working on adding a section to the documentation of 2.1.0 on how to configure SSL, let me know if you want to review it.


Reply to this email directly or view it on GitHubhttps://github.com//issues/239#issuecomment-109891843.

@ohej
Copy link
Contributor

ohej commented Jun 8, 2015

I've sent you an email with directions, please let me know how it works out

@mindthegab
Copy link
Contributor

@ohej @hagak Did this work? can we close this?

@mindthegab mindthegab removed the wontfix label Aug 6, 2015
@hagak
Copy link
Author

hagak commented Aug 6, 2015

This did not resolve the issue in SDK 1.2 however we are moving to SDK 2.0 so this may no longer be an issue for us. (Not moving to 2.1 until it support Java 1.7)

@mindthegab
Copy link
Contributor

Yeah we are releasing SDK 2.1.1 soon with Java 7 support. I'll close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants