Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functional-testing profile could be organized better in AIO #343

Closed
jrosler opened this issue Nov 4, 2015 · 1 comment
Closed

functional-testing profile could be organized better in AIO #343

jrosler opened this issue Nov 4, 2015 · 1 comment

Comments

@jrosler
Copy link

jrosler commented Nov 4, 2015

In runner/pom.xml, the functional-testing profile has the configuration block above the execution blocks. I'd think that would make it hard to test more than one share AMP without moving the configuration block into the execution blocks.

It'd be nice if this was configured better by defaultd to allow for functional tests for multiple share AMPS in the AIO to be run.

Below is how it looks by default

                    <plugin>
                        <groupId>org.apache.maven.plugins</groupId>
                        <artifactId>maven-failsafe-plugin</artifactId>
                        <version>2.18.1</version>
                        <configuration>
                            <suiteXmlFiles>
                                <suiteXmlFile>${project.parent.basedir}/share-amp/target/test-classes/testng.xml</suiteXmlFile>
                            </suiteXmlFiles>
                            <testClassesDirectory>${project.parent.basedir}/share-amp/target/test-classes</testClassesDirectory>
                            <systemPropertyVariables>
                                <!-- Where is the Alfresco Share Webapp that we are testing -->
                                <share.target>${share.client.url}</share.target>
                            </systemPropertyVariables>
                        </configuration>
                        <executions>
                            <execution>
                                <id>functional-tests</id>
                                <phase>integration-test</phase>
                                <goals>
                                    <goal>integration-test</goal>
                                </goals>
                            </execution>
                            <execution>
                                <id>verify-tests</id>
                                <phase>verify</phase>
                                <goals>
                                    <goal>verify</goal>
                                </goals>
                            </execution>
                        </executions>
                    </plugin>
@ohej ohej closed this as completed Mar 24, 2017
@ohej
Copy link
Contributor

ohej commented Mar 24, 2017

I don't know why my comment wasn't put in here when I closed the issue.

We have decided to reduce the complexity of the default archetypes in SDK3. The functional testing is complex and impossible to do in a backwards compatible way and most people would want to start customising it anyways.

As a result we don't include the functional testing in the AIO archetype anymore, but are planning to include documentation and samples on how to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants