change activation of enforce-sdk-rules so it's *really* on by default, as intended #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohej
added a commit
that referenced
this pull request
Feb 4, 2016
change activation of enforce-sdk-rules so it's *really* on by default, as intended
|
Thanks for the contribution! :) |
ohej
added a commit
that referenced
this pull request
Feb 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven's "active by default" does behave intuitively. If you turn on any other profiles, then the "active by default" ones are turned off.
As a result, using the "enterprise" profile turns off "enforce-sdk-rules", which I believe was unintended.
I use a bit of a hack to fix this (looking for a non-existent file).
From the maven docs: "All profiles that are active by default are automatically deactivated when a profile in the POM is activated on the command line or through its activation config."
http://maven.apache.org/guides/introduction/introduction-to-profiles.html