Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for Catalyst v13.0.0 #106

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Conversation

slwu89
Copy link
Member

@slwu89 slwu89 commented Feb 25, 2023

Catalyst 13.0.0 is a breaking change (https://github.com/SciML/Catalyst.jl/blob/master/HISTORY.md), @variables is no longer recognized, which is causing the CatalystInterop tests to fail. Do we also want to add Catalyst to the [extras] part of the package, and maybe a [compat] for versions >= 13.0.0?

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! Also yeah I think we definitely should add this to the extra dependencies with a version requirement.

@slwu89
Copy link
Member Author

slwu89 commented Feb 26, 2023

Thanks for the quick check @mehalter! Added it to Project.toml

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mehalter mehalter merged commit 2cb84b9 into AlgebraicJulia:master Feb 26, 2023
@slwu89 slwu89 deleted the slwu89/catalyst branch February 26, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants