Fix MCA recursion overflowing #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… currently for dubgging mca. Has mca_help2 that fixes part of the recursion, but one_removed_subobs still needs to be debugged. Uses DataStructures.jl
…oves the subobj rather than trims it) to test/SubACSets.jl
…king (with rm_cascade_subobj), but could use further checks and cleanup prior to moving to src.
…on't return duplicates. Also included new version of strip_names to work on unlabeled Petri nets.
…etermination of the morphisms and spans, in addition to the apex, for the mca.
…he larger mca input acset
mehalter
force-pushed
the
pas/mca_recursion
branch
2 times, most recently
from
0dac379
to
ec36b63
Compare
mehalter
force-pushed
the
pas/mca_recursion
branch
from
ec36b63
to
0f1cb59
Compare
mehalter
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
mcanot searching/recursing correctly. Resolves #127, resolves #128, resolves #129Adds function to obtain the morphisms