-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to define operation aliases in block form #129
Conversation
Cool! What about doing the syntax like
That makes more sense from a math notation perspective. |
I just made a change that will currently allow you to define them in the notation that James brought up, or the same notation that is used for the single line definitions. Once we decide on a specific version to use, I can remove the other in the |
I would also strongly prefer to settle on a single notation. I think I slightly prefer James' notation, but here I don't feel as strongly. |
Yeah I think the |
Cool I think this PR is ready once the tests pass. |
For consistency, shouldn't we use the same syntax in the short form of |
Yeah I think that is more consistent |
New code looks good to me. I like this interface a lot |
Added a second notation for
@op
macro inside of the@theory
Also updated tests to make sure both notations work, and found a typo/bug in one of the ParseError definitions