Find C-set homomorphisms using conjunctive queries #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epatters
force-pushed
the
query-return-type
branch
from
aac614a
to
40003c2
Compare
The `query` function, the only function that still required TypedTables, now by default returns a DataFrame if that package is loaded and a NamedTuple otherwise.
epatters
force-pushed
the
query-return-type
branch
from
40003c2
to
41aec1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the C-set homomorphism finding functions to have different algorithmic backends. In addition to backtracking search, which was already supported, the conjunctive query machinery can now be used to find homomorphisms. Thanks to @olynch for doing the original implementation of this feature. The implementation here also supports data attributes.
I also take the opportunity to remove the dependency on TypedTables, no longer needed after the struct acsets refactor. An optional dependency on DataFrames is added so that the
queryfunction can return a table when possible.