Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL: do not flush metrics from threads #13366

Merged
merged 1 commit into from
Aug 11, 2024
Merged

DPL: do not flush metrics from threads #13366

merged 1 commit into from
Aug 11, 2024

Conversation

ktf
Copy link
Member

@ktf ktf commented Aug 10, 2024

DPL: do not flush metrics from threads

This avoids having to have a mutex for the flushing.

This avoids having to have a mutex for the flushing.
@ktf ktf requested a review from a team as a code owner August 10, 2024 14:31
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@ktf
Copy link
Member Author

ktf commented Aug 11, 2024

Tested on hyperloop as well. Sending on preLoop should guarantee that the GUI gets updated correctly both in synchronous and asynchronous mode.

@ktf ktf merged commit 3269ab5 into AliceO2Group:dev Aug 11, 2024
12 checks passed
@ktf ktf deleted the pr13366 branch August 11, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant