Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ITS ROF orbit/BC intead of dummy ROFrame in ITS/TPC macthing #1904

Closed
wants to merge 1 commit into from

Conversation

shahor02
Copy link
Collaborator

Synchronization of ITS and TPC tracks during the matchin is now based
on the ITS trigger (or ROF) InteractionRecord instead of the artificial
cycle counter.

Synchronization of ITS and TPC tracks during the matchin is now based
on the ITS trigger (or ROF) InteractionRecord instead of the artificial
cycle counter.
@shahor02
Copy link
Collaborator Author

Hi
Could somebody hint what this failed test build/o2checkcode/o2 complains about? To me it does not look to be related to my PR.

Exception in thread Thread-15:
Traceback (most recent call last):
  File "/mnt/mesos/sandbox/sandbox/sw/slc7_x86-64/Python/v3.6.8-3/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/mnt/mesos/sandbox/sandbox/sw/slc7_x86-64/Python/v3.6.8-3/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/mnt/mesos/sandbox/sandbox/sw/slc7_x86-64/o2codechecker/master-2/bin/ThinCompilationsDatabase.py", line 119, in processItem
    includedheaderlist=queryListOfHeaders(modifyCompileCommand(entry['command']))
  File "/mnt/mesos/sandbox/sandbox/sw/slc7_x86-64/o2codechecker/master-2/bin/ThinCompilationsDatabase.py", line 107, in queryListOfHeaders
    if matchesHeader(line.strip(), headerlist):
  File "/mnt/mesos/sandbox/sandbox/sw/slc7_x86-64/o2codechecker/master-2/bin/ThinCompilationsDatabase.py", line 101, in matchesHeader
    return re.match(expression, line) is not None
  File "/mnt/mesos/sandbox/sandbox/sw/slc7_x86-64/Python/v3.6.8-3/lib/python3.6/re.py", line 172, in match
    return _compile(pattern, flags).match(string)
TypeError: cannot use a string pattern on a bytes-like object
input queue has size 0
output queue has size 0
input queue has size 777
output queue has size 1
input queue has size 777
...

@shahor02
Copy link
Collaborator Author

Closing as this patch is included in #1906

@shahor02 shahor02 closed this Apr 27, 2019
@shahor02 shahor02 deleted the dev_tpcitsBC branch June 1, 2020 21:31
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Apr 15, 2023
* Few improvements in the impact parameter workflow

 1. add number of contributors axis for post-processing analyses
 2. remove the gemoetry loading, not used

* Fix Clang format.

---------

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant