Fix unused variable #2012
Merged
Fix unused variable #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktf
requested review from
alibuild,
chiarazampolli and
noferini
as code owners
njacazio
previously approved these changes
Feb 16, 2023
ktf
requested review from
a team,
jgrosseo,
iarsene and
ddobrigk
as code owners
|
Actually, we need to drop almost all of them. I suggest we move to explicitly handled errors on warning, so that we do not get hit by different defaults with different compilers. If you want some warning to become an error, first fix all the instances and then enable it. |
lvermunt
pushed a commit
to lvermunt/O2Physics
that referenced
this pull request
Mar 1, 2023
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.