Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation warnings #2531

Open
vkucera opened this issue May 3, 2023 · 14 comments
Open

Fix compilation warnings #2531

vkucera opened this issue May 3, 2023 · 14 comments
Assignees
@vkucera
Labels
bug Something isn't working

Comments

@vkucera
Copy link
Collaborator

vkucera commented May 3, 2023 •
edited
Loading

O2Physics compilation warnings are not treated as errors by default since #2012 to avoid breaking the CI checks when a new warning is introduced by a compiler. Only explicitly listed warnings make the CI check fail.

If one wants a warning to become an error, all instances have to be fixed first and then the warning can be added in the CMAKE_CXX_FLAGS variable in dependencies/O2PhysicsCompileFlags.cmake.

Currently checked warnings (reference):

  • -Wunused-variable
@vkucera vkucera added the bug Something isn't working label Sep 5, 2023
@vkucera
Copy link
Collaborator Author

vkucera commented Mar 25, 2024

@vkucera
Copy link
Collaborator Author

vkucera commented Apr 2, 2024

@vkucera
Copy link
Collaborator Author

vkucera commented Apr 2, 2024 •
edited
Loading

@vkucera
Copy link
Collaborator Author

vkucera commented Apr 2, 2024

@vkucera vkucera pinned this issue Apr 11, 2024
@vkucera
Copy link
Collaborator Author

vkucera commented Apr 17, 2024

@vkucera
Copy link
Collaborator Author

vkucera commented Apr 18, 2024 •
edited
Loading

@vkucera
Copy link
Collaborator Author

vkucera commented Apr 22, 2024

@vkucera
Copy link
Collaborator Author

vkucera commented Apr 23, 2024

@vkucera
Copy link
Collaborator Author

vkucera commented Apr 23, 2024 •
edited
Loading

Related PR:

Treats warnings as errors only in CI tests by adding -Werror if $ALIBUILD_O2_TESTS is set. This allows to compile locally despite warnings.

However, if we want to avoid breaking CI with new warnings, we have to provide an explicit list, which is better done inside O2PhysicsCompileFlags.cmake instead of inside the alidist recipe.
It would therefore be useful to have a switch equivalent to ALIBUILD_O2_TESTS inside O2PhysicsCompileFlags.cmake.

@vkucera
Copy link
Collaborator Author

vkucera commented Jun 11, 2024

@vkucera vkucera self-assigned this Jun 11, 2024
@vkucera
Copy link
Collaborator Author

vkucera commented Jun 22, 2024

@vkucera
Copy link
Collaborator Author

vkucera commented Jul 2, 2024

@vkucera
Copy link
Collaborator Author

vkucera commented Jul 9, 2024

@vkucera
Copy link
Collaborator Author

vkucera commented Jul 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkucera vkucera

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vkucera