Trigger compilation errors on warnings #5445

vkucera · 2024-04-02T10:04:58Z

Trigger compilation errors on warnings from the following categories:

default,
-Wall,
-Wextra.

Warnings present in at least one of the categories above are grouped into the following lists:

common (present for both clang 15 (Mac builds) and gcc 12 (Linux builds)),
only clang,
only gcc.

Lists were taken from https://github.com/pkolbus/compiler-warnings

-Wsign-compare will be added later when cleaned up in the current code base (hundreds).

Requires:

O2Physics: Add a CMake flag to treat warnings as errors alisw/alidist#5516

alibuild · 2024-04-02T16:41:48Z

Error while checking build/O2Physics/o2 for ccee6b2 at 2024-04-02 18:41:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:132:124: error: missing braces around initializer for 'std::__array_traits<std::__cxx11::basic_string<char>, 13>::_Type' {aka 'std::__cxx11::basic_string<char> [13]'} [-Werror=missing-braces]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:137:66: error: missing braces around initializer for 'std::__array_traits<float, 13>::_Type' {aka 'float [13]'} [-Werror=missing-braces]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/TPCPIDResponse.h:89:145: error: missing braces around initializer for 'std::__array_traits<float, 5>::_Type' {aka 'float [5]'} [-Werror=missing-braces]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/TPCPIDResponse.h:90:61: error: missing braces around initializer for 'std::__array_traits<float, 2>::_Type' {aka 'float [2]'} [-Werror=missing-braces]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/TableProducer/trackextension.cxx:81:44: error: missing braces around initializer for 'std::__array_traits<float, 2>::_Type' {aka 'float [2]'} [-Werror=missing-braces]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/TableProducer/trackextension.cxx:119:44: error: missing braces around initializer for 'std::__array_traits<float, 2>::_Type' {aka 'float [2]'} [-Werror=missing-braces]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/trackUtilities.h:30:51: error: missing braces around initializer for 'std::__array_traits<float, 5>::_Type' {aka 'float [5]'} [-Werror=missing-braces]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/trackUtilities.h:30:51: error: missing braces around initializer for 'std::__array_traits<float, 5>::_Type' {aka 'float [5]'} [-Werror=missing-braces]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:132:124: error: missing braces around initializer for 'std::__array_traits<std::__cxx11::basic_string<char>, 13>::_Type' {aka 'std::__cxx11::basic_string<char> [13]'} [-Werror=missing-braces]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:137:66: error: missing braces around initializer for 'std::__array_traits<float, 13>::_Type' {aka 'float [13]'} [-Werror=missing-braces]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:132:124: error: missing braces around initializer for 'std::__array_traits<std::__cxx11::basic_string<char>, 13>::_Type' {aka 'std::__cxx11::basic_string<char> [13]'} [-Werror=missing-braces]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:137:66: error: missing braces around initializer for 'std::__array_traits<float, 13>::_Type' {aka 'float [13]'} [-Werror=missing-braces]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2024-04-22T17:47:29Z

Error while checking build/O2Physics/o2 for 13e49af at 2024-04-24 02:28:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/ParamBase.h:186:3: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/ParamBase.h:186:3: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/TPCPIDResponse.h:65:3: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/TPCPIDResponse.h:66:3: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/TPCPIDResponse.h:67:3: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/TPCPIDResponse.h:68:3: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/TPCPIDResponse.h:69:3: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/TableProducer/trackselection.cxx:76:250: error: this statement may fall through [-Werror=implicit-fallthrough=]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/TableProducer/trackselection.cxx:83:9: error: this statement may fall through [-Werror=implicit-fallthrough=]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/TableProducer/trackselection.cxx:90:9: error: this statement may fall through [-Werror=implicit-fallthrough=]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/TableProducer/trackselection.cxx:97:9: error: this statement may fall through [-Werror=implicit-fallthrough=]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2024-04-24T19:06:00Z

Error while checking build/O2Physics/o2 for 99f1307 at 2024-04-30 06:51:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/ParamBase.h:186:3: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2024-04-30T17:42:46Z

Error while checking build/O2Physics/o2 for 15994c1 at 2024-05-16 09:40:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/Common/Core/PID/ParamBase.h:186:3: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
ninja: build stopped: subcommand failed.

Full log here.

vkucera · 2024-05-17T11:58:57Z

To be finalised after SQM. (Following up on the discussion at WP14.)

github-actions · 2024-06-17T01:21:15Z

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

alibuild · 2024-07-02T01:16:09Z

Error while checking build/O2Physics/o2 for 75fb9c0 at 2024-07-10 05:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/PWGHF/D2H/Tasks/taskSigmacToCascade.cxx:61:26: error: unused parameter 'context' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/PWGHF/D2H/Tasks/taskSigmacToCascade.cxx:132:42: error: unused parameter 'candidatesLc' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

vkucera · 2024-07-02T14:25:22Z

Can you check if this does not explode the log size?

It does not.

ktf · 2024-07-08T09:53:18Z

There is some other warning -> error. Could you have a look?

vkucera · 2024-07-08T10:09:28Z

There is some other warning -> error. Could you have a look?

If you can confirm that this PR looks fine for you, I'm ready to open PRs fixing the existing warnings so that this one can pass the build tests.

vkucera · 2024-07-09T08:55:10Z

There is some other warning -> error. Could you have a look?

If you can confirm that this PR looks fine for you, I'm ready to open PRs fixing the existing warnings so that this one can pass the build tests.

Let me rephrase: If all the build tests pass, will you be fine with approving and merging this PR as it is now?

victor-gonzalez

Thanks!! @vkucera

alibuild · 2024-07-10T18:26:46Z

Error while checking build/O2Physics/o2 for b233d8c at 2024-07-10 20:26:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/PWGUD/Tasks/upcTauCentralBarrelRL.cxx:1979:28: error: unused parameter 'reconstructedCollision' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/5445-slc7_x86-64/0/PWGUD/Tasks/upcTauCentralBarrelRL.cxx:1979:28: error: unused parameter 'reconstructedCollision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

…to warnings

vkucera · 2024-07-11T04:34:16Z

There is some other warning -> error. Could you have a look?

@ktf All green now. Can you please approve?

victor-gonzalez

Thanks!! @vkucera

vkucera mentioned this pull request Apr 2, 2024

Fix compilation warnings #2531

Open

vkucera marked this pull request as ready for review April 2, 2024 16:27

vkucera requested review from alibuild, jgrosseo, iarsene, ktf, ddobrigk and a team as code owners April 2, 2024 16:27

vkucera marked this pull request as draft April 2, 2024 17:06

vkucera changed the title ~~Add more compilation warnings on the error list~~ Trigger compilation errors on warnings Apr 20, 2024

vkucera force-pushed the warnings branch from ccee6b2 to 7743106 Compare April 22, 2024 11:03

vkucera marked this pull request as ready for review April 22, 2024 11:05

vkucera marked this pull request as draft May 17, 2024 11:56

github-actions bot added the stale label Jun 17, 2024

vkucera removed the stale label Jun 17, 2024

vkucera force-pushed the warnings branch from 15994c1 to 46e1d4d Compare June 22, 2024 00:17

vkucera marked this pull request as ready for review June 22, 2024 00:20

vkucera marked this pull request as draft June 22, 2024 01:48

vkucera marked this pull request as ready for review June 23, 2024 11:16

vkucera marked this pull request as draft June 23, 2024 11:17

vkucera added 4 commits June 23, 2024 13:18

Trigger compilation errors on warnings for default + all + extra

bb02bdb

Enable extra warnings

92e195a

Remove C++ version compatibility flags

5bdbc99

Treat warnings as errors only in CI tests.

f82462c

vkucera added 3 commits July 10, 2024 14:02

Merge branch 'master' into warnings

9f85f95

Merge branch 'master' into warnings

2019359

Fix unused-parameter

f3b49c9

vkucera requested review from saganatt, victor-gonzalez and zchochul as code owners July 10, 2024 14:34

victor-gonzalez previously approved these changes Jul 10, 2024

View reviewed changes

Fix unused-parameter

b233d8c

vkucera dismissed victor-gonzalez’s stale review via b233d8c July 10, 2024 16:22

vkucera requested review from pbuehler, abylinkin and rolavick as code owners July 10, 2024 16:22

rolavick previously approved these changes Jul 10, 2024

View reviewed changes

vkucera added 2 commits July 10, 2024 23:28

Merge branch 'master' of https://github.com/AliceO2Group/O2Physics in…

2024d90

…to warnings

Fix unused-parameter

6a87381

vkucera dismissed rolavick’s stale review via 6a87381 July 10, 2024 21:39

vkucera added 2 commits July 10, 2024 23:53

Fix unused-parameter

fb118d7

Fix unused-parameter

2af4156

vkucera requested review from ktf, victor-gonzalez and rolavick July 11, 2024 04:33

victor-gonzalez approved these changes Jul 11, 2024

View reviewed changes

ktf merged commit c31daaa into AliceO2Group:master Jul 11, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trigger compilation errors on warnings #5445

Trigger compilation errors on warnings #5445

vkucera commented Apr 2, 2024 •

edited

Loading

alibuild commented Apr 2, 2024

alibuild commented Apr 22, 2024 •

edited

Loading

alibuild commented Apr 24, 2024 •

edited

Loading

alibuild commented Apr 30, 2024 •

edited

Loading

vkucera commented May 17, 2024

github-actions bot commented Jun 17, 2024

alibuild commented Jul 2, 2024 •

edited

Loading

vkucera commented Jul 2, 2024

ktf commented Jul 8, 2024

vkucera commented Jul 8, 2024

vkucera commented Jul 9, 2024

victor-gonzalez left a comment

alibuild commented Jul 10, 2024

vkucera commented Jul 11, 2024

victor-gonzalez left a comment

Trigger compilation errors on warnings #5445

Trigger compilation errors on warnings #5445

Conversation

vkucera commented Apr 2, 2024 • edited Loading

alibuild commented Apr 2, 2024

alibuild commented Apr 22, 2024 • edited Loading

alibuild commented Apr 24, 2024 • edited Loading

alibuild commented Apr 30, 2024 • edited Loading

vkucera commented May 17, 2024

github-actions bot commented Jun 17, 2024

alibuild commented Jul 2, 2024 • edited Loading

vkucera commented Jul 2, 2024

ktf commented Jul 8, 2024

vkucera commented Jul 8, 2024

vkucera commented Jul 9, 2024

victor-gonzalez left a comment

Choose a reason for hiding this comment

alibuild commented Jul 10, 2024

vkucera commented Jul 11, 2024

victor-gonzalez left a comment

Choose a reason for hiding this comment

vkucera commented Apr 2, 2024 •

edited

Loading

alibuild commented Apr 22, 2024 •

edited

Loading

alibuild commented Apr 24, 2024 •

edited

Loading

alibuild commented Apr 30, 2024 •

edited

Loading

alibuild commented Jul 2, 2024 •

edited

Loading