PWGJE: Fix compilation warnings: unused-parameter #5669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkucera
requested review from
alibuild,
maoyx,
nzardosh,
ddobrigk and
mfasDa
as code owners
nzardosh
reviewed
Apr 18, 2024
| @@ -115,7 +115,7 @@ struct JetTaggerHFTask { | |||
| } | |||
| PROCESS_SWITCH(JetTaggerHFTask, processMCD, "Fill tagging decision for mcd jets", false); | |||
|
|
|||
| void processTraining(JetCollision const& collision, JetTableMCD const& mcdjets, JetTagTracksMCD const& tracks) | |||
| void processTraining(JetCollision const& /*collision*/, JetTableMCD const& /*mcdjets*/, JetTagTracksMCD const& /*tracks*/) | |||
There was a problem hiding this comment.
these can be removed fully instead of commented out
There was a problem hiding this comment.
I kept them because the function body is empty so I guess, you will need the parameters when you implement it.
PWGJE/TableProducer/rhoEstimator.cxx
Outdated
| @@ -78,7 +78,7 @@ struct RhoEstimatorTask { | |||
| } | |||
| PROCESS_SWITCH(RhoEstimatorTask, processChargedCollisions, "Fill rho tables for collisions using charged tracks", true); | |||
|
|
|||
| void processD0Collisions(JetCollision const& collision, soa::Filtered<JetTracks> const& tracks, CandidatesD0Data const& candidates) | |||
| void processD0Collisions(JetCollision const& /*collision*/, soa::Filtered<JetTracks> const& tracks, CandidatesD0Data const& candidates) | |||
There was a problem hiding this comment.
these can be removed fully instead of commented out
PWGJE/TableProducer/rhoEstimator.cxx
Outdated
| @@ -91,7 +91,7 @@ struct RhoEstimatorTask { | |||
| } | |||
| PROCESS_SWITCH(RhoEstimatorTask, processD0Collisions, "Fill rho tables for collisions with D0 candidates", false); | |||
|
|
|||
| void processLcCollisions(JetCollision const& collision, soa::Filtered<JetTracks> const& tracks, CandidatesLcData const& candidates) | |||
| void processLcCollisions(JetCollision const& /*collision*/, soa::Filtered<JetTracks> const& tracks, CandidatesLcData const& candidates) | |||
There was a problem hiding this comment.
these can be removed fully instead of commented out
PWGJE/TableProducer/rhoEstimator.cxx
Outdated
| @@ -104,7 +104,7 @@ struct RhoEstimatorTask { | |||
| } | |||
| PROCESS_SWITCH(RhoEstimatorTask, processLcCollisions, "Fill rho tables for collisions with Lc candidates", false); | |||
|
|
|||
| void processBplusCollisions(JetCollision const& collision, soa::Filtered<JetTracks> const& tracks, CandidatesBplusData const& candidates) | |||
| void processBplusCollisions(JetCollision const& /*collision*/, soa::Filtered<JetTracks> const& tracks, CandidatesBplusData const& candidates) | |||
There was a problem hiding this comment.
these can be removed fully instead of commented out
| @@ -544,7 +544,7 @@ struct JetTriggerQA { | |||
| } | |||
|
|
|||
| template <typename JetCollection> | |||
| std::pair<std::vector<typename JetCollection::iterator>, std::vector<typename JetCollection::iterator>> fillJetQA(const JetCollection& jets, JetTracks const& tracks, selectedClusters const& clusters, std::bitset<EMCALHardwareTrigger::TRG_NTriggers> hwtrg, const std::bitset<TriggerType_t::kNTriggers>& triggerstatus) | |||
| std::pair<std::vector<typename JetCollection::iterator>, std::vector<typename JetCollection::iterator>> fillJetQA(const JetCollection& jets, JetTracks const& /*tracks*/, selectedClusters const& /*clusters*/, std::bitset<EMCALHardwareTrigger::TRG_NTriggers> /*hwtrg*/, const std::bitset<TriggerType_t::kNTriggers>& triggerstatus) | |||
There was a problem hiding this comment.
these can be removed fully instead of commented out
There was a problem hiding this comment.
Are you sure? This is not a process function.
| @@ -494,7 +494,7 @@ struct JetTaggerHFQA { | |||
| } | |||
|
|
|||
| template <typename T, typename U> | |||
| void fillHistogramJPData(T const& collision, U const& jets) | |||
There was a problem hiding this comment.
here please comment out instead of remove
| @@ -512,7 +512,7 @@ struct JetTaggerHFQA { | |||
| } | |||
|
|
|||
| template <typename T, typename U> | |||
| void fillHistogramJPMCD(T const& collision, U const& mcdjets) | |||
There was a problem hiding this comment.
here please comment out instead of remove
PWGJE/Tasks/jettaggerhfQA.cxx
Outdated
| @@ -512,7 +512,7 @@ struct JetTaggerHFQA { | |||
| } | |||
|
|
|||
| template <typename T, typename U> | |||
| void fillHistogramJPMCD(T const& collision, U const& mcdjets) | |||
| void fillHistogramJPMCD(T const&, U const& mcdjets) | |||
There was a problem hiding this comment.
here please comment out instead of remove
nzardosh
approved these changes
Apr 18, 2024
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.