Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: Fix compilation warnings #5764

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Common: Fix compilation warnings #5764

merged 7 commits into from
Jun 10, 2024

Conversation

vkucera
Copy link
Collaborator

@vkucera vkucera commented Apr 22, 2024 •
edited
Loading

ignored-qualifiers
sign-compare
implicit-fallthrough

@vkucera vkucera mentioned this pull request Apr 22, 2024
Open
@vkucera vkucera marked this pull request as ready for review April 22, 2024 10:23
@vkucera
Copy link
Collaborator Author

vkucera commented Apr 24, 2024

@jgrosseo @iarsene @ktf @ddobrigk Can you check, please?

@vkucera
Copy link
Collaborator Author

vkucera commented Apr 30, 2024

@jgrosseo @iarsene @ktf @ddobrigk Bump

@vkucera vkucera marked this pull request as draft May 17, 2024 11:56
ddobrigk
ddobrigk approved these changes Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@ddobrigk ddobrigk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@vkucera vkucera marked this pull request as ready for review June 10, 2024 09:21
@vkucera vkucera merged commit a16b28d into AliceO2Group:master Jun 10, 2024
11 checks passed
@vkucera vkucera deleted the fix-Common branch June 10, 2024 09:28
GiorgioAlbertoLucia pushed a commit to GiorgioAlbertoLucia/O2Physics that referenced this pull request Jul 9, 2024
@vkucera @GiorgioAlbertoLucia
Common: Fix compilation warnings (AliceO2Group#5764)
31d67e7
echizzal pushed a commit to echizzal/O2Physics that referenced this pull request Jul 18, 2024
@vkucera @echizzal
Common: Fix compilation warnings (AliceO2Group#5764)
04370a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalkin aalkin aalkin left review comments

@njacazio njacazio njacazio approved these changes

@ddobrigk ddobrigk ddobrigk approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vkucera @njacazio @aalkin @ddobrigk @alibuild