Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWGCF: Fix compilation warnings #6474

Merged
merged 4 commits into from
Jun 11, 2024
Merged

PWGCF: Fix compilation warnings #6474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b95948
PWGCF: Fix compilation warnings
vkucera Jun 11, 2024
3555ea2
Please consider the following formatting changes (#81)
alibuild Jun 11, 2024
f14540d
Fix missing-braces
vkucera Jun 11, 2024
9c9eeb4
Pass object to TNamed constructor
vkucera Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,8 @@ struct FactorialMoments {
h->Reset();
}
countTracks = {0, 0, 0, 0, 0};
fqEvent = {0, 0, 0, 0, 0, 0};
binConEvent = {0, 0, 0, 0, 0};
fqEvent = {{{0, 0, 0, 0, 0, 0}}};
binConEvent = {{0, 0, 0, 0, 0}};

for (auto const& track : tracks) {
if ((track.pt() < confPtMin) || (!track.isGlobalTrack()) || (track.tpcNClsFindable() < confMinTPCCls)) {
Expand Down Expand Up @@ -260,8 +260,8 @@ struct FactorialMoments {
}

countTracks = {0, 0, 0, 0, 0};
fqEvent = {0, 0, 0, 0, 0, 0};
binConEvent = {0, 0, 0, 0, 0};
fqEvent = {{{0, 0, 0, 0, 0, 0}}};
binConEvent = {{0, 0, 0, 0, 0}};

for (auto const& track : tracks) {
if ((track.pt() < confPtMin) || (!track.isGlobalTrack()) || (track.tpcNClsFindable() < confMinTPCCls)) {
Expand Down
6 changes: 3 additions & 3 deletions PWGCF/EbyEFluctuations/Tasks/IdentifiedMeanPtFluctuations.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,11 +392,11 @@ struct IdentifiedMeanPtFluctuations {
template <class T>
void SelTPCTOFProtons(const T& track1)
{
if (track1.hasTPC() && track1.hasTOF() && track1.p() >= 1.1 && TMath::Hypot((track1.tofNSigmaPi() + 2) / 3.0, (track1.tpcNSigmaPi() - 6) / 4.0) > 3. && TMath::Hypot((track1.tofNSigmaKa() + 2) / 3.0, (track1.tpcNSigmaKa() - 6) / 4.0) > 3. && TMath::Hypot((track1.tofNSigmaPr() + 2) / 3.0, (track1.tpcNSigmaPr() - 6) / 4.0) < 3.)
;
if (track1.hasTPC() && track1.hasTOF() && track1.p() >= 1.1 && TMath::Hypot((track1.tofNSigmaPi() + 2) / 3.0, (track1.tpcNSigmaPi() - 6) / 4.0) > 3. && TMath::Hypot((track1.tofNSigmaKa() + 2) / 3.0, (track1.tpcNSigmaKa() - 6) / 4.0) > 3. && TMath::Hypot((track1.tofNSigmaPr() + 2) / 3.0, (track1.tpcNSigmaPr() - 6) / 4.0) < 3.) {
};
}

void processMCReco(aod::MyMCRecoCollisions::iterator const& mccoll, aod::MyMCRecoTracks const& mcrectrack, aod::McParticles const& mcParticles)
void processMCReco(aod::MyMCRecoCollisions::iterator const& mccoll, aod::MyMCRecoTracks const& mcrectrack, aod::McParticles const& /*mcParticles*/)
{
if (!mccoll.has_mcCollision()) {
return;
Expand Down
2 changes: 1 addition & 1 deletion PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2294,7 +2294,7 @@ struct RobustFluctuationObservables {
} // end of processRobustFluctuationObservables()

// shortcut function to fill 2D histograms
void fillHistForThisCut(string cutName, int multNTracksPV, int multTrk, int nTracksGlobalAccepted, double multT0A, double multT0C, double multV0A, double t0cCentr, int bc)
void fillHistForThisCut(string cutName, int multNTracksPV, int multTrk, int nTracksGlobalAccepted, double multT0A, double multT0C, double multV0A, double /*t0cCentr*/, int bc)
{
// registry.get<TH1>(HIST("eta"))->Fill(track.eta());
// arrPointers[histId][cutId]->Fill(xval, yval, weight);
Expand Down
2 changes: 1 addition & 1 deletion PWGCF/Femto3D/Tools/checkPacking.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ bool process(std::string outputName, int nevents = 100000)
return gausOk && uniformOk;
}

int main(int argc, char* argv[])
int main(int /*argc*/, char* /*argv*/[])
{

LOG(info) << "Checking the packing and unpacking of PID signals (nsigmas) in the Femto PID response.";
Expand Down
2 changes: 1 addition & 1 deletion PWGCF/FemtoDream/Tasks/femtoDreamDebugTrack.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ struct femtoDreamDebugTrack {
/// \param col subscribe to FemtoDreamCollision table
/// \param parts subscribe to the joined table of FemtoDreamParticles and FemtoDreamMCLabels table
/// \param FemtoDramMCParticles subscribe to the table containing the Monte Carlo Truth information
void processMC(FemtoMCCollision& col, o2::aod::FDMCCollisions&, FemtoFullParticlesMC& parts, aod::FDMCParticles&, aod::FDExtMCParticles&)
void processMC(FemtoMCCollision& col, o2::aod::FDMCCollisions&, FemtoFullParticlesMC& /*parts*/, aod::FDMCParticles&, aod::FDExtMCParticles&)
{
auto groupPartsOne = partsOneMC->sliceByCached(aod::femtodreamparticle::fdCollisionId, col.globalIndex(), cache);
FillDebugHistos<true>(col, groupPartsOne);
Expand Down
2 changes: 1 addition & 1 deletion PWGCF/FemtoUniverse/Tasks/femtoUniverseEfficiencyTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ struct femtoUniverseEficiencyTask {

using BigTracksMC = soa::Join<TracksPID, aod::McTrackLabels, aod::TrackSelection>;
Preslice<BigTracksMC> perCollisionID = aod::track::collisionId;
void processMCTruth(aod::McCollision const& collision, soa::SmallGroups<soa::Join<aod::McCollisionLabels, aod::Collisions>> const& collisions, aod::McParticles const& mcparticles, soa::Filtered<BigTracksMC> const& tracks)
void processMCTruth(aod::McCollision const& /*collision*/, soa::SmallGroups<soa::Join<aod::McCollisionLabels, aod::Collisions>> const& collisions, aod::McParticles const& mcparticles, soa::Filtered<BigTracksMC> const& tracks)
{
// Loop over reconstructed collisions corresponding to MC collision
for (auto& collision : collisions) {
Expand Down
6 changes: 3 additions & 3 deletions PWGCF/Flow/Tasks/FlowZDCtask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ struct FlowZDCtask {
}
}

void processQVector(aodCollisions::iterator const& collision, aod::BCsWithTimestamps const&, aodTracks const& tracks, BCsRun3 const& bcs, aod::Zdcs const& zdcsData, aod::ZDCMults const& zdcMults)
void processQVector(aodCollisions::iterator const& collision, aod::BCsWithTimestamps const&, aodTracks const& tracks, BCsRun3 const& /*bcs*/, aod::Zdcs const& /*zdcsData*/, aod::ZDCMults const& /*zdcMults*/)
{
histos.fill(HIST("eventCounter"), 0.5);
histos.fill(HIST("centHistogram"), collision.centFT0C());
Expand Down Expand Up @@ -227,8 +227,8 @@ struct FlowZDCtask {
}
void processZdcCollAssoc(
ColEvSels const& cols,
BCsRun3 const& bcs,
aod::Zdcs const& zdcs)
BCsRun3 const& /*bcs*/,
aod::Zdcs const& /*zdcs*/)
{
double sumCosPsiDiff = 0.0; // initialize Sum of cosPsiDiff for averaging
double sumSinPsiDiff = 0.0; // initialize Sum of cosPsiDiff for averaging
Expand Down
15 changes: 9 additions & 6 deletions PWGCF/JCorran/Core/JFFlucAnalysis.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
#include <algorithm>
#include "JFFlucAnalysis.h"

JFFlucAnalysis::JFFlucAnalysis() : fVertex(0),
JFFlucAnalysis::JFFlucAnalysis() : TNamed(),
fVertex(0),
fCent(0),
fImpactParameter(-1),
subeventMask(kSubEvent_A | kSubEvent_B),
Expand All @@ -29,7 +30,8 @@ JFFlucAnalysis::JFFlucAnalysis() : fVertex(0),
}

//________________________________________________________________________
JFFlucAnalysis::JFFlucAnalysis(const char* /*name*/) : fVertex(0),
JFFlucAnalysis::JFFlucAnalysis(const char* /*name*/) : TNamed(),
fVertex(0),
fCent(0),
fImpactParameter(-1),
subeventMask(kSubEvent_A | kSubEvent_B),
Expand All @@ -41,7 +43,8 @@ JFFlucAnalysis::JFFlucAnalysis(const char* /*name*/) : fVertex(0),
}

//________________________________________________________________________
JFFlucAnalysis::JFFlucAnalysis(const JFFlucAnalysis& a) : fVertex(a.fVertex),
JFFlucAnalysis::JFFlucAnalysis(const JFFlucAnalysis& a) : TNamed(a),
fVertex(a.fVertex),
fCent(a.fCent),
fImpactParameter(a.fImpactParameter),
subeventMask(a.subeventMask),
Expand Down Expand Up @@ -124,7 +127,7 @@ TComplex JFFlucAnalysis::Four(int n1, int n2, int n3, int n4)
#undef C

//________________________________________________________________________
void JFFlucAnalysis::UserExec(Option_t* popt)
void JFFlucAnalysis::UserExec(Option_t* /*popt*/)
{
TComplex corr[kNH][nKL];
TComplex ncorr[kNH][nKL];
Expand Down Expand Up @@ -289,7 +292,7 @@ void JFFlucAnalysis::UserExec(Option_t* popt)
}

for (UInt_t ih = 2; ih < kNH; ih++) {
for (UInt_t ihh = 2, mm = (ih < kcNH ? ih : kcNH); ihh < mm; ihh++) {
for (UInt_t ihh = 2, mm = (ih < kcNH ? ih : static_cast<UInt_t>(kcNH)); ihh < mm; ihh++) {
TComplex scfour = Four(ih, ihh, -ih, -ihh) / Four(0, 0, 0, 0).Re();

pht[HIST_THN_SC_with_QC_4corr]->Fill(fCent, ih, ihh, scfour.Re(), event_weight_four);
Expand All @@ -305,7 +308,7 @@ void JFFlucAnalysis::UserExec(Option_t* popt)
}

//________________________________________________________________________
void JFFlucAnalysis::Terminate(Option_t* popt)
void JFFlucAnalysis::Terminate(Option_t* /*popt*/)
{
//
}
Loading