Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWGCF: Fix compilation warnings #6474

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

vkucera
Copy link
Collaborator

@vkucera vkucera commented Jun 11, 2024

unused-parameter
missing constructor
non-enum vs enum in conditional expression
missing-braces

@vkucera vkucera marked this pull request as ready for review June 11, 2024 12:04
@vkucera vkucera marked this pull request as draft June 11, 2024 14:04
@vkucera vkucera marked this pull request as ready for review June 11, 2024 14:14
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkucera Thanks for doing this!!!
Just a minor request from my side

PWGCF/JCorran/Core/JFFlucAnalysis.cxx Outdated Show resolved Hide resolved
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@vkucera vkucera enabled auto-merge (squash) June 11, 2024 15:18
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @vkucera.

@vkucera vkucera merged commit 1ce3614 into AliceO2Group:master Jun 11, 2024
11 of 13 checks passed
@vkucera vkucera deleted the PWGCF-warnings branch June 11, 2024 21:05
GiorgioAlbertoLucia pushed a commit to GiorgioAlbertoLucia/O2Physics that referenced this pull request Jul 9, 2024
* PWGCF: Fix compilation warnings

* Please consider the following formatting changes (AliceO2Group#81)

* Fix missing-braces

* Pass object to TNamed constructor

---------

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants