Common: Event selection: Fix compilation warning #6721
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkucera
requested review from
alibuild,
jgrosseo,
iarsene,
ktf,
ddobrigk and
a team
as code owners
|
hello @vkucera , thanks for the optimisation - yes, the logic is preserved |
altsybee
approved these changes
Jul 3, 2024
jgrosseo
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@altsybee This fixes the
int-in-bool-contextwarning introduced in #6548 and also fixes the unnecessary evaluation of the condition and assignment when the result is already known.Please check carefully that the logic has been preserved.