Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OGUI-1459] Refactor Lock API to allow for future easy improvements addition #2241

Merged
merged 18 commits into from
May 30, 2024

Conversation

graduta
Copy link
Member

@graduta graduta commented Jan 22, 2024

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

PR which:

  • update API routes to follow convention on both front-end and back-end
  • adds controller for lock requests
  • adds service for lock operations
  • adds DTOs for Lock and User plus conversions for JSON for private attributes)
  • updates and complements back-end tests accordingly

Future improvements are needed as:

  • using cache service for keeping track of locks
  • allowing one request per lock operation
  • allowing the take/release of multiple locks at the same time

@graduta graduta merged commit 6dd44f2 into dev May 30, 2024
2 of 4 checks passed
@graduta graduta deleted the feature/COG/OGUI-1459/refactor-lock-api branch May 30, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant