Skip to content

Commit

Permalink
Fix Unit Tests, remove unused import
Browse files Browse the repository at this point in the history
Ref #256
  • Loading branch information
algorys committed Mar 10, 2018
1 parent 9a7e474 commit 1b73362
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 14 deletions.
2 changes: 0 additions & 2 deletions alignak_app/qobjects/events/item.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
Event item manage creation of ``QListWidgetItem`` for events
"""

import time

from PyQt5.Qt import QTimer, QColor, QListWidgetItem, QIcon

from alignak_app.utils.config import settings
Expand Down
6 changes: 3 additions & 3 deletions alignak_app/utils/time.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def get_local_datetime_from_date(_date):
:rtype: datetime.datetime
"""

# Backend is set in EN, so temp set locale
# Backend is set in EN, so temporary setlocale to assert format success
if 'win32' in sys.platform:
locale.setlocale(locale.LC_ALL, 'eng')
else:
Expand All @@ -62,7 +62,7 @@ def get_local_datetime_from_date(_date):
return local_time


def get_local_datetime(_date):
def get_local_datetime(_date): # pragma: no cover
"""
Return the local time from a datetime
Expand Down Expand Up @@ -131,7 +131,7 @@ def get_time_diff_since_last_timestamp(timestamp):
return _('%s ago') % time_diff


def get_current_time():
def get_current_time(): # pragma: no cover
"""
Return current formatted time
Expand Down
14 changes: 5 additions & 9 deletions test/test_panel_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,9 @@
from alignak_app.items.service import Service

from alignak_app.qobjects.panel import PanelQWidget
from alignak_app.qobjects.events.spy import SpyQWidget


class TestLoginQDialog(unittest2.TestCase):
class TestPanelQWidget(unittest2.TestCase):
"""
This file test the PanelQWidget class.
"""
Expand Down Expand Up @@ -111,12 +110,11 @@ def test_create_widget(self):
self.assertIsNotNone(under_test.host_widget)
self.assertIsNotNone(under_test.services_widget)
self.assertIsNotNone(under_test.spy_button)
self.assertIsNotNone(under_test.spy_widget)

self.assertIsNone(under_test.spy_widget)
self.assertFalse(under_test.hostnames_list)

spy_widget_test = SpyQWidget()
under_test.initialize(spy_widget_test)
under_test.initialize()

self.assertIsNotNone(under_test.layout)
self.assertIsNotNone(under_test.line_search)
Expand All @@ -125,9 +123,8 @@ def test_create_widget(self):
self.assertIsNotNone(under_test.host_widget)
self.assertIsNotNone(under_test.services_widget)
self.assertIsNotNone(under_test.spy_button)

self.assertIsNotNone(under_test.spy_widget)
self.assertTrue(under_test.hostnames_list)

self.assertEqual(
['host0', 'host1', 'host2', 'host3', 'host4', 'host5', 'host6', 'host7', 'host8', 'host9'],
under_test.hostnames_list
Expand All @@ -137,8 +134,7 @@ def test_spy_host(self):
"""Panel Add Spy Host"""

under_test = PanelQWidget()
spy_widget_test = SpyQWidget()
under_test.initialize(spy_widget_test)
under_test.initialize()

# Host is not in hostname_list
under_test.line_search.setText('no_host')
Expand Down
3 changes: 3 additions & 0 deletions test/test_spy_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@

from alignak_app.qobjects.events.spy import SpyQWidget, SpyQListWidget
from alignak_app.qobjects.events.item import EventItem
from alignak_app.qobjects.events.events import init_event_widget

init_event_widget()


class TestDataManager(unittest2.TestCase):
Expand Down

0 comments on commit 1b73362

Please sign in to comment.