Enhance cron_grafana (add argument to force recreate dashboard and li… #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddurieux
force-pushed
the
develop+cron_grafana_enhance
branch
from
5440bf5
to
4b35664
Compare
mohierf
requested changes
Jan 18, 2017
| items = hosts_db.find({'ls_grafana': False, '_realm': {"$in": children}, | ||
| 'ls_perf_data': {"$ne": ""}, '_is_template': False}) | ||
| search['_realm'] = {"$in": children} | ||
| items = hosts_db.find(search) |
There was a problem hiding this comment.
No more need to include _is_template ? It will generate a dashboard for the templates also, no?
There was a problem hiding this comment.
Ignore this comment ... I got it 😉
| @@ -1753,28 +1762,40 @@ def cron_grafana(engine='jsonify'): | |||
| if graf.connection: | |||
| # get the realms of the grafana | |||
| realm = realm_db.find_one({'_id': grafana['_realm']}) | |||
| search = {'_realm': realm['_id'], '_is_template': False} | |||
| if forcegenerate is not None: | |||
| print("[cron_grafana] Force generation of grafana dashboard") | |||
There was a problem hiding this comment.
Please indicate which grafana instance is concerned
|
I am currently testing on my server and I will probably commit some small modifications soon... |
mohierf
force-pushed
the
develop+cron_grafana_enhance
branch
3 times, most recently
from
c6db424
to
61305ff
Compare
|
I made many modifications to improve the dashboard building and I tested with the demo configuration on my own test servers with graphite / statsd / grafana ... great results! |
- add a parameter to force rebuilding the dashboards Improve Grafana dashboard creation: - add some prints to get logs - improve DB requests - set datasource name as alignak-source-name instead of _id - sanitize metrics name - add templating in dahsboard for the stats/graphite prefixs - improve metric target build: variables, alias - add series override for legend and color - set ref and label for warning/critical/min/max
mohierf
force-pushed
the
develop+cron_grafana_enhance
branch
from
d1a2ed6
to
b866e4f
Compare
mohierf
approved these changes
Jan 19, 2017
This was referenced Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mit this endpoint to localhost)