Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #256: % formatted performance data #257

Merged
merged 1 commit into from Jan 24, 2017
Merged

Fixes #256: % formatted performance data #257

merged 1 commit into from Jan 24, 2017

Conversation

mohierf
Copy link
Collaborator

@mohierf mohierf commented Jan 23, 2017

Manage min and max correctly

@mohierf mohierf requested a review from ddurieux January 23, 2017 04:38
@mohierf mohierf changed the title Fixes #256: % formatted performance data [Wip] Fixes #256: % formatted performance data Jan 23, 2017
@mohierf mohierf changed the title [Wip] Fixes #256: % formatted performance data Fixes #256: % formatted performance data Jan 24, 2017
@coveralls
Copy link

coveralls commented Jan 24, 2017

Coverage Status

Coverage increased (+0.4%) to 47.476% when pulling 1f16c24 on fix-#256 into 16405a7 on develop.

@@ -77,7 +77,19 @@ def prepare_data(item):
m = re.search(r'^(.*)\.[\d]{10}$', fields['name'])
if m:
fields['name'] = m.group(1)
fields['name'] = fields['name'].replace(" ", "_")

# Sanitize field name for Graphite:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanitize field name for timeserie database, in this case it's for graphite and influxdb

Copy link
Collaborator Author

@mohierf mohierf Jan 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, Influxdb do not have such constraints on field names, as such it is not necessary to change the fields names

Oups, I was meaning the contrary of what I wrote ... whereas it is for Graphite or Influx, metrics outgoing from Alignak will have the same name

'value': fields['max'],
'uom': fields['uom']
}
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 cool ;)

Manage min and max correctly
Sanitize metrics names for Graphite/Grafana
Set version as 0.8.5.1
@coveralls
Copy link

coveralls commented Jan 24, 2017

Coverage Status

Coverage increased (+0.4%) to 47.476% when pulling c211992 on fix-#256 into 16405a7 on develop.

@ddurieux ddurieux merged commit d7a4ac0 into develop Jan 24, 2017
@ddurieux ddurieux deleted the fix-#256 branch January 24, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants