#261 - compute overall state #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # alignak_backend/timeseries.py
mohierf
changed the title
mohierf
changed the title
mohierf
force-pushed
the
#261
branch
6 times, most recently
from
0e0196e
to
35c0839
Compare
Compute overall host/service state on insertion Fix broken tests
ddurieux
suggested changes
Jan 28, 2017
alignak_backend/app.py
Outdated
|
|
||
| # Host overall was computed, update the host overall state | ||
| lookup = {"_id": item['_id']} | ||
| patch_internal('host', {"_overall_state_id": overall_state}, False, False, **lookup) |
There was a problem hiding this comment.
I think (but not sure) the patch_internal modify the _etag, so need return the new _etag. if we don't do this the _etag returned by the post method will be wrong
There was a problem hiding this comment.
Îndeed, yes, it modifies the _etag. this is why I had to modify the tests ... but how do you modify the returned _etag? Please do the modification ...
|
I added code to have the right (new) etag in the response |
mohierf
commented
Feb 1, 2017
ddurieux
approved these changes
Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.