Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set version specifier in setup.py dependencies #515

Merged
merged 1 commit into from Jun 7, 2018

Conversation

mohierf
Copy link
Collaborator

@mohierf mohierf commented Jun 7, 2018

Setting version in the setup.py creates incompatible librairies installation. The requirements.txt is the only file where dependencies must be specified. Setup.py is only referred to as abstract dependencies for development purposes

@mohierf mohierf merged commit b0ddd3c into develop Jun 7, 2018
@mohierf mohierf deleted the clean-requirements branch June 7, 2018 11:56
@coveralls
Copy link

coveralls commented Jun 7, 2018

Coverage Status

Coverage remained the same at 90.252% when pulling d0c2591 on clean-requirements into 46f5ac6 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants