Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property hostgroup_members in Hostgroup class #110

Closed
ddurieux opened this issue Jun 24, 2015 · 7 comments · Fixed by #396
Closed

Add property hostgroup_members in Hostgroup class #110

ddurieux opened this issue Jun 24, 2015 · 7 comments · Fixed by #396

Comments

@ddurieux
Copy link
Contributor

When comment modules (pylint), I have seen the function get_hostgroup_members of Hostgroup never works because property 'hostgroup_members' not exist.

So clean it and remove the call in function 'get_hosts_by_explosion' in same class

@ddurieux ddurieux added the clean label Jun 24, 2015
@mohierf
Copy link
Contributor

mohierf commented Jun 25, 2015

Please do not remove ! This function is really useful for a Web UI ...

I made a PR in Shinken (shinken-solutions/shinken#1654) to add the missing property in the hostgroup and servicegroupe class !

@mohierf
Copy link
Contributor

mohierf commented Jun 25, 2015

It is not possible to add this function in the module because the parsing of the configuration files is made elsewhere!

Moreover I think that it is not a good idea to ignore standard Nagios object definition:

define hostgroup{
   hostgroup_name   hostgroup_name
   alias    alias
   members  hosts
   hostgroup_members    hostgroups
   notes    note_string 
   notes_url    url
   action_url   url
}

@ddurieux
Copy link
Contributor Author

Ok, so it's the opposite, add hostgroup_members property in the class Hostgroup

@ddurieux ddurieux changed the title Clean function of Hostgroup not used Add property hostgroup_members in Hostgroup class Jun 25, 2015
@mohierf
Copy link
Contributor

mohierf commented Jun 25, 2015

And servicegroup_members in the class Servicegroup ;-)

@gst
Copy link
Contributor

gst commented Aug 24, 2015

any PR yet ? ;)

@mohierf
Copy link
Contributor

mohierf commented Aug 28, 2015

Not yet in Alignak, but I proposed this PR in Shinken : shinken-solutions/shinken#1654

@gst
Copy link
Contributor

gst commented Sep 25, 2015

ping ?

mohierf added a commit that referenced this issue Sep 12, 2016
Remove old test test_groups_pickle
mohierf added a commit that referenced this issue Sep 12, 2016
Remove old test testgroups_with_no_alias
@ddurieux ddurieux added this to the 1.0 milestone Sep 13, 2016
ddurieux pushed a commit that referenced this issue Sep 13, 2016
WiP: Clean elements groups and refactor configuration warnings/errors logging
ddurieux pushed a commit that referenced this issue Sep 13, 2016
Remove old test test_groups_pickle
ddurieux pushed a commit that referenced this issue Sep 13, 2016
Remove old test testgroups_with_no_alias
ddurieux pushed a commit that referenced this issue Sep 18, 2016
Remove old test test_groups_pickle
ddurieux pushed a commit that referenced this issue Sep 18, 2016
Remove old test testgroups_with_no_alias
Seb-Solon pushed a commit that referenced this issue Sep 18, 2016
Remove old test test_groups_pickle
Seb-Solon pushed a commit that referenced this issue Sep 18, 2016
Remove old test testgroups_with_no_alias
ddurieux pushed a commit that referenced this issue Sep 18, 2016
Remove old test test_groups_pickle
ddurieux pushed a commit that referenced this issue Sep 18, 2016
Remove old test testgroups_with_no_alias
ddurieux pushed a commit that referenced this issue Sep 18, 2016
Remove old test test_groups_pickle
ddurieux pushed a commit that referenced this issue Sep 18, 2016
Remove old test testgroups_with_no_alias
ddurieux pushed a commit that referenced this issue Sep 18, 2016
Remove old test test_groups_pickle
ddurieux pushed a commit that referenced this issue Sep 18, 2016
Remove old test testgroups_with_no_alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants