Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTHORS file update on setup.py #370

Closed
mohierf opened this issue Sep 27, 2016 · 4 comments
Closed

AUTHORS file update on setup.py #370

mohierf opened this issue Sep 27, 2016 · 4 comments

Comments

@mohierf
Copy link
Contributor

mohierf commented Sep 27, 2016

When the setup.py script runs, it updates the AUTHORS file because of pbr ... we must choose if this file should be updated thanks to pbr or not ...

The same problem exists with the ChangeLog file built by pbr ... we already have a Changelog (lowercase L) file ...

@mohierf
Copy link
Contributor Author

mohierf commented Sep 28, 2016

Because this modification is really easy, we should do it. I propose to:

  • rename the current AUTHORS files as AUTHORS.md,
  • rename the current Changelog file as Changelog.md,
  • include the two pbr files in the .gitignore (AUTHORS and Changelog)

As of it there will be no confusion with the pbr generated files ... and this will avoid mistakes with commits 😉

@Seb-Solon, @ddurieux : please vote for this

@Seb-Solon
Copy link
Contributor

Seb-Solon commented Sep 29, 2016

https://github.com/openstack-dev/pbr/blob/64699d79bec5f0955566aa9129a6b9dbf686035f/doc/source/packagers.rst

pbr generates AUTHORS and ChangeLog files from git information. This can cause problem in distro packaging if package maintainer is using git repository for packaging source. If that is the case setting
SKIP_GENERATE_AUTHORS

SKIP_GENERATE_AUTHORS=1

will cause logic around generating AUTHORS using git information to be skipped. Similarly setting SKIP_WRITE_GIT_CHANGELOG

SKIP_WRITE_GIT_CHANGELOG=1

will cause logic around generating ChangeLog file using git information to be skipped.

Does that fit your need?

@mohierf
Copy link
Contributor Author

mohierf commented Sep 29, 2016

Yes it does ...

@mohierf
Copy link
Contributor Author

mohierf commented Sep 29, 2016

As discussed with @Seb-Solon , we should define these environment variables in the setup.py script if they do not exist. @ddurieux ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants