Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker images #1106

Closed
wants to merge 13 commits into from
Closed

Docker images #1106

wants to merge 13 commits into from

Conversation

palvarezcordoba
Copy link

No description provided.

mohierf and others added 13 commits May 9, 2019 19:15
@mohierf
Protect against a potential encoding error
32c4833
@mohierf
Manage missing executable file for a check command
f792f40
Merge remote-tracking branch 'origin/develop' into develop
fafa589
Merge remote-tracking branch 'origin/develop' into develop
37da68b
Alignak Docker images:
6d26a3a 
- base image
- Web UI image
@palvarezcordoba
cleanup
716ceaa
@palvarezcordoba
use volumes and an entrypoint to fix permissions
e1749db
@palvarezcordoba
fix LIBEXEC path
00f744f
Alignak Web UI image with nginx as a front server
9fadbd6
@palvarezcordoba
move entrypoint to its corresponding dir
5dbd84d
@palvarezcordoba
don't use a named volume for alignak
fc12cef
@palvarezcordoba
Merge remote-tracking branch 'origin/docker-images-tmp' into docker-i…
3295132 
…mages-tmp
@palvarezcordoba
Merge branch 'docker-images-tmp' into docker-images
23ef52c 
# Conflicts:
#	docker/.env
#	docker/README
#	docker/data/alignak/etc/alignak.d/extra-daemons.ini
#	docker/data/alignak/etc/alignak.d/modules.ini
#	docker/data/alignak/etc/alignak.ini
#	docker/docker-compose.yml
#	docker/image-alignak-ui/Dockerfile
#	docker/image-alignak-ui/alignak-webui.conf
#	docker/image-alignak-ui/nginx.conf
#	docker/image-alignak/Dockerfile
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #1106 into docker-images will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           docker-images    #1106     +/-   ##
================================================
- Coverage          85.23%   85.13%   -0.1%     
================================================
  Files                102      102             
  Lines              17607    17607             
================================================
- Hits               15007    14990     -17     
- Misses              2600     2617     +17
Flag Coverage Δ
#tests 85.13% <ø> (-0.1%) ⬇️
#tests_integ 61.35% <ø> (-0.18%) ⬇️
Impacted Files Coverage Δ
alignak/satellite.py 81.87% <0%> (-2.56%) ⬇️
alignak/scheduler.py 91.69% <0%> (-0.48%) ⬇️
alignak/daemon.py 83.52% <0%> (-0.14%) ⬇️
alignak/objects/notificationway.py 88.97% <0%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c565cf...23ef52c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 16, 2019 •
edited
Loading

Codecov Report

Merging #1106 into docker-images will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           docker-images    #1106     +/-   ##
================================================
- Coverage          85.23%   85.13%   -0.1%     
================================================
  Files                102      102             
  Lines              17607    17607             
================================================
- Hits               15007    14990     -17     
- Misses              2600     2617     +17
Flag Coverage Δ
#tests 85.13% <ø> (-0.1%) ⬇️
#tests_integ 61.35% <ø> (-0.18%) ⬇️
Impacted Files Coverage Δ
alignak/satellite.py 81.87% <0%> (-2.56%) ⬇️
alignak/scheduler.py 91.69% <0%> (-0.48%) ⬇️
alignak/daemon.py 83.52% <0%> (-0.14%) ⬇️
alignak/objects/notificationway.py 88.97% <0%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c565cf...23ef52c. Read the comment docs.

@mohierf
Copy link
Contributor

mohierf commented Jun 5, 2019

@palvarezcordoba : what is to be done with this PR? Is is still relevant if we consider #1107 ?

An sorry for the delay... :/

@palvarezcordoba
Copy link
Author

@mohierf The most important part is fixing a problem with permissions. If a run docker-compose up Alignak fails because lack of permissions on data dir.
But there is some wrong things in this PR. I'll do it better and create another PR soon.

Sorry for the inconvenience and thanks.

@mohierf
Copy link
Contributor

mohierf commented Jun 5, 2019

@palvarezcordoba thanks for the explanations. I understood the insterest of your endpoint.sh script +1 I worked on the Docker images tonight and I will submi some modifications probably tomorrow or Friday ... stay tuned 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@palvarezcordoba @mohierf