[WiP] - Add a multi-realms test in the load test suite #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohierf
force-pushed
the
test-load-multi-realms
branch
from
1eb79fe
to
a3c94da
Compare
ddurieux
suggested changes
Aug 29, 2017
alignak/daemons/arbiterdaemon.py
Outdated
| result = False | ||
| else: | ||
| logger.info("%s running (pid=%d)", | ||
| daemon_name, self.my_satellites[daemon_name].pid) | ||
| return result | ||
|
|
||
| def stop_missing_daemons(self): |
There was a problem hiding this comment.
This function has many problems:
- in comment, it's written
stop the daemonbut in code it just look if stopped, not try stop it - in comment we have
True if all daemons are stopped, else False, but in code it return True only in case all daemons are running
alignak/daemons/arbiterdaemon.py
Outdated
| @@ -784,6 +816,9 @@ def do_loop_turn(self): | |||
| # Main loop | |||
| self.run() | |||
|
|
|||
| if self.interrupted: | |||
| self.stop_missing_daemons() | |||
There was a problem hiding this comment.
after my previous comment, we not use the return status, perhaps manage it
mohierf
changed the title
|
@ddurieux, please merge this ... |
|
But you not see my comments... :p |
Add a multi-realms test with undefined daemons Clean daemons launch and stop
mohierf
force-pushed
the
test-load-multi-realms
branch
from
bd6864e
to
066c83f
Compare
|
I deprecate this in favor of #990 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.