Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default value of stalking_options property #903

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Fix default value of stalking_options property #903

merged 1 commit into from
Aug 29, 2017

Conversation

ddurieux
Copy link
Contributor

No description provided.

@ddurieux ddurieux requested a review from mohierf August 24, 2017 12:01
@ddurieux
Copy link
Contributor Author

In the backend, the '' value is not allowed for stalking_options so when import cfg we can have problem

@mohierf
Copy link
Contributor

mohierf commented Aug 28, 2017

The test for the default value of the properties is broken .... please fix it

@ddurieux ddurieux force-pushed the master+fix_stalking_options_default branch from f137fd8 to 343fe0a Compare August 28, 2017 08:42
@ddurieux ddurieux force-pushed the master+fix_stalking_options_default branch from 343fe0a to 6652162 Compare August 28, 2017 08:51
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 84.847% when pulling 6652162 on master+fix_stalking_options_default into 66f4217 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 84.975% when pulling 6652162 on master+fix_stalking_options_default into 66f4217 on develop.

@coveralls
Copy link

coveralls commented Aug 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 84.847% when pulling 6652162 on master+fix_stalking_options_default into 66f4217 on develop.

@mohierf mohierf merged commit ff1f3b5 into develop Aug 29, 2017
@mohierf mohierf deleted the master+fix_stalking_options_default branch August 29, 2017 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohierf mohierf Awaiting requested review from mohierf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ddurieux @mohierf @coveralls