Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transfer experiments with KataGo-raw #60

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Conversation

norabelrose
Copy link
Contributor

@norabelrose norabelrose commented Nov 11, 2022

Unfortunately due to the apparent discrepancies between analysis and (our version of) match, it's become necessary to check that our attacks "transfer" to KataGo-raw.

The raw-gtp.cfg file is necessary because KataGo-raw doesn't support config options with player indices in GTP mode. Also it forces you to specify explicitly that ponderingEnabled=false.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #60 (ff47145) into main (085b57b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           81        81           
=========================================
  Hits            81        81           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

compose/transfer/compose.yml Show resolved Hide resolved
configs/raw-gtp.cfg Outdated Show resolved Hide resolved
configs/raw-gtp.cfg Outdated Show resolved Hide resolved
Copy link
Collaborator

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo adding comment about why we're copy-pasting from base.cfg (and what we're modifying)

@norabelrose norabelrose merged commit a8142c4 into main Nov 11, 2022
@norabelrose norabelrose deleted the katago-raw-transfer branch November 11, 2022 01:25
@tomtseng
Copy link
Contributor

I'm having trouble figuring out what commit 42892e for KataGo-raw is — navigating to https://github.com/HumanCompatibleAI/KataGo-custom/tree/42892ea19b4256803ba7a0ff18d1096a84d11fe6 gives me a 404

@tomtseng
Copy link
Contributor

I'm having trouble figuring out what commit 42892e for KataGo-raw is — navigating to https://github.com/HumanCompatibleAI/KataGo-custom/tree/42892ea19b4256803ba7a0ff18d1096a84d11fe6 gives me a 404

fixed, needed to pull the latest upstream changes from lightvector/KataGo into a branch in HumanCompatibleAI/KataGo-custom

I put it in branch master in KataGo-custom. The README says that this is supposed to track lightvector/KataGo, but we had one extra commit AlignmentResearch/KataGo-custom#2 in master. I'm guessing this was a mistake — the commit also got cherrypicked into stable by Tony. I removed that commit and just force pushed the latest commits from lightvector/KataGo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants