Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django > 1.4 compatibility #4

Merged
merged 6 commits into from
May 3, 2014
Merged

Django > 1.4 compatibility #4

merged 6 commits into from
May 3, 2014

Conversation

Alir3z4
Copy link
Owner

@Alir3z4 Alir3z4 commented Apr 19, 2014

No description provided.

@Alir3z4
Copy link
Owner Author

Alir3z4 commented Apr 19, 2014

@daniell this is great, if you don't have any further changes I'll merge this.

@daniell
Copy link

daniell commented Apr 19, 2014

I've just noticed that the tests haven't been updated. I'm not sure if
you want to let that block the request, but it's a simple enough change
to make. If you don't, then go ahead and merge. Otherwise, let me know
and I'll sort it out during the next couple of weeks.

On 19/04/2014 14:26, Alireza Savand wrote:

@daniell https://github.com/daniell this is great, if you don't have
any further changes I'll merge this.


Reply to this email directly or view it on GitHub
#4 (comment).

@Alir3z4
Copy link
Owner Author

Alir3z4 commented Apr 19, 2014

I'm not in hurry to merge, please feel free to hack whenever you got the
time ;)
meanwhile I work on some other parts such as travis-ci and running tests in
tox.

On Sat, Apr 19, 2014 at 10:00 PM, daniell notifications@github.com wrote:

I've just noticed that the tests haven't been updated. I'm not sure if
you want to let that block the request, but it's a simple enough change
to make. If you don't, then go ahead and merge. Otherwise, let me know
and I'll sort it out during the next couple of weeks.

On 19/04/2014 14:26, Alireza Savand wrote:

@daniell https://github.com/daniell this is great, if you don't have
any further changes I'll merge this.


Reply to this email directly or view it on GitHub
#4 (comment).


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-40876170
.

@daniell
Copy link

daniell commented Apr 28, 2014

OK, I've updated the tests. Feel free to merge the pull request.

@Alir3z4
Copy link
Owner Author

Alir3z4 commented May 3, 2014

Brilliant, thanks ;)

Alir3z4 added a commit that referenced this pull request May 3, 2014
Django > 1.4 compatibility
@Alir3z4 Alir3z4 merged commit 130ba60 into Alir3z4:master May 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants