Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support set ipv4 or ipv6 when create container #2840

Merged
merged 1 commit into from
May 13, 2019

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented May 13, 2019

Ⅰ. Describe what this PR did

support set ipv4 or ipv6 to container when create new container.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Added

Ⅳ. Describe how to verify it

ci pass

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

support set ipv4 or ipv6 to container when create new container.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #2840 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2840      +/-   ##
==========================================
- Coverage      69%   68.94%   -0.07%     
==========================================
  Files         285      285              
  Lines       17824    17840      +16     
==========================================
  Hits        12300    12300              
- Misses       4119     4133      +14     
- Partials     1405     1407       +2
Flag Coverage Δ
#criv1alpha2_test 38.95% <0%> (-0.06%) ⬇️
#integration_test_0 36.56% <0%> (-0.05%) ⬇️
#integration_test_1 35.74% <0%> (+0.42%) ⬆️
#integration_test_2 36.55% <0%> (+0.02%) ⬆️
#integration_test_3 35.39% <0%> (-0.05%) ⬇️
#node_e2e_test 34.69% <0%> (-0.13%) ⬇️
#unittest 28.54% <0%> (-0.04%) ⬇️
Impacted Files Coverage Δ
apis/opts/networks.go 77.77% <0%> (-19.15%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
daemon/logger/crilog/log.go 79.71% <0%> (-2.9%) ⬇️
daemon/containerio/io.go 72.81% <0%> (-1.95%) ⬇️
ctrd/container.go 53.15% <0%> (-0.77%) ⬇️
cri/v1alpha2/cri.go 68.81% <0%> (-0.51%) ⬇️
daemon/mgr/container.go 60.35% <0%> (+0.83%) ⬆️
daemon/mgr/network.go 73.15% <0%> (+0.84%) ⬆️
cri/ocicni/netns.go 60.81% <0%> (+2.7%) ⬆️

Copy link
Contributor

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants