Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distinguish image name and ref #2902

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

zhuangqh
Copy link
Contributor

Signed-off-by: zhuangqh zhuangqhc@gmail.com

Ⅰ. Describe what this PR did

after introduce the registry-mirror feature. the image name
and the ref is not the same. using image name for user-interface
operation, ref to communicate with image registry.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@zhuangqh zhuangqh requested a review from fuweid June 11, 2019 14:59
@pouchrobot pouchrobot added kind/bug This is bug report for project size/XL labels Jun 11, 2019
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #2902 into master will increase coverage by 0.21%.
The diff coverage is 79.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2902      +/-   ##
==========================================
+ Coverage    68.7%   68.91%   +0.21%     
==========================================
  Files         291      291              
  Lines       18238    18259      +21     
==========================================
+ Hits        12530    12583      +53     
+ Misses       4244     4231      -13     
+ Partials     1464     1445      -19
Flag Coverage Δ
#criv1alpha2_test 38.37% <77.21%> (+0.01%) ⬆️
#integration_test_0 36.25% <77.21%> (+0.04%) ⬆️
#integration_test_1 35.67% <77.21%> (+0.03%) ⬆️
#integration_test_2 36.18% <77.21%> (+0.02%) ⬆️
#integration_test_3 35.73% <79.74%> (ø) ⬆️
#node_e2e_test 34.37% <79.74%> (+0.31%) ⬆️
#unittest 28.01% <0%> (-0.04%) ⬇️
Impacted Files Coverage Δ
daemon/mgr/image.go 61.36% <60%> (-0.16%) ⬇️
ctrd/utils.go 75.97% <80.59%> (-2.98%) ⬇️
ctrd/image.go 67.52% <85.71%> (+0.62%) ⬆️
pkg/streams/utils.go 82.14% <0%> (-7.15%) ⬇️
daemon/mgr/container.go 60.35% <0%> (+0.41%) ⬆️
daemon/mgr/container_utils.go 77.77% <0%> (+1.01%) ⬆️
ctrd/supervisord/daemon.go 50.67% <0%> (+1.35%) ⬆️
cri/v1alpha2/cri.go 69.57% <0%> (+1.51%) ⬆️
pkg/meta/store.go 68.99% <0%> (+1.55%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
... and 4 more

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the CI issue

after introduce the registry-mirror feature. the image name
and the ref is not the same. using image name for user-interface
operation.

Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants