Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search images api methods #2905

Merged

Conversation

hellolijj
Copy link
Contributor

Signed-off-by: Junjun Li junjunli666@gmail.com

Ⅰ. Describe what this PR did

fix bug: search images api methods

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Junjun Li <junjunli666@gmail.com>
@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #2905 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2905      +/-   ##
==========================================
+ Coverage   68.73%   68.89%   +0.15%     
==========================================
  Files         291      291              
  Lines       18259    18259              
==========================================
+ Hits        12551    12579      +28     
+ Misses       4246     4228      -18     
+ Partials     1462     1452      -10
Flag Coverage Δ
#criv1alpha2_test 38.41% <50%> (+0.01%) ⬆️
#integration_test_0 36.23% <50%> (+0.01%) ⬆️
#integration_test_1 35.64% <50%> (-0.02%) ⬇️
#integration_test_2 36.18% <50%> (-0.02%) ⬇️
#integration_test_3 35.76% <50%> (+0.04%) ⬆️
#node_e2e_test 34.23% <50%> (+0.12%) ⬆️
#unittest 28.01% <50%> (ø) ⬆️
Impacted Files Coverage Δ
client/image_search.go 100% <100%> (ø) ⬆️
apis/server/router.go 91.51% <100%> (ø) ⬆️
cri/ocicni/netns.go 58.1% <0%> (-2.71%) ⬇️
daemon/mgr/container.go 60.35% <0%> (+0.41%) ⬆️
cri/v1alpha2/cri.go 69.06% <0%> (+0.75%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
ctrd/container.go 53.91% <0%> (+2.29%) ⬆️
apis/server/utils.go 75% <0%> (+3.84%) ⬆️
ctrd/watch.go 78.37% <0%> (+5.4%) ⬆️

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Jun 14, 2019
@ZYecho
Copy link
Contributor

ZYecho commented Jun 14, 2019

LGTM

@allencloud allencloud merged commit 02deee8 into AliyunContainerService:master Jun 14, 2019
@hellolijj hellolijj deleted the fix-image-search-method branch June 15, 2019 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants