Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic reload cni default config #2949

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

zhuangqh
Copy link
Contributor

Signed-off-by: zhuangqh zhuangqhc@gmail.com

Ⅰ. Describe what this PR did

related to alibaba-archive/ocicni#2

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #2949 into master will decrease coverage by 2.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2949      +/-   ##
==========================================
- Coverage    68.1%   65.99%   -2.11%     
==========================================
  Files         291      291              
  Lines       18347    18347              
==========================================
- Hits        12495    12109     -386     
- Misses       4386     4819     +433     
+ Partials     1466     1419      -47
Flag Coverage Δ
#criv1alpha2_test 34.8% <ø> (+0.01%) ⬆️
#integration_test_0 36.13% <ø> (-0.01%) ⬇️
#integration_test_1 ?
#integration_test_2 36.07% <ø> (-0.03%) ⬇️
#integration_test_3 35.61% <ø> (+0.04%) ⬆️
#node_e2e_test 34.15% <ø> (ø) ⬆️
#unittest 27.95% <ø> (ø) ⬆️
Impacted Files Coverage Δ
ctrd/image_commit.go 0% <0%> (-69.29%) ⬇️
daemon/mgr/container_commit.go 0% <0%> (-56.1%) ⬇️
daemon/mgr/container_copy.go 38.32% <0%> (-19.17%) ⬇️
apis/server/copy_bridge.go 46.93% <0%> (-16.33%) ⬇️
daemon/mgr/container_exec.go 65.04% <0%> (-14.64%) ⬇️
pkg/reference/def.go 77.77% <0%> (-11.12%) ⬇️
daemon/mgr/network_utils.go 30.43% <0%> (-10.87%) ⬇️
daemon/mgr/events.go 87.5% <0%> (-9.73%) ⬇️
pkg/streams/utils.go 79.76% <0%> (-9.53%) ⬇️
apis/server/network_bridge.go 57.25% <0%> (-8.88%) ⬇️
... and 17 more

@pouchrobot pouchrobot added areas/network kind/bug This is bug report for project size/M labels Jul 15, 2019
@rudyfly
Copy link
Collaborator

rudyfly commented Jul 15, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 15, 2019
@rudyfly rudyfly merged commit 1f864c9 into AliyunContainerService:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/network kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants