Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase timeout to avoid false negatives #49

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

Alkaar
Copy link
Owner

@Alkaar Alkaar commented Oct 1, 2022

Sometimes the book API call can take longer than 5 seconds to respond back. So increasing the timeout to avoid incorrectly erroring out that a reservation was not found when in fact, it could have been.

  • Increase book reservation API call timeout from 5 to 10 seconds

@Alkaar Alkaar added the fix A bug fix label Oct 1, 2022
@Alkaar Alkaar self-assigned this Oct 1, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 55.28% // Head: 55.28% // No change to project coverage 👍

Coverage data is based on head (59e11fa) compared to base (8cbeb27).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   55.28%   55.28%           
=======================================
  Files           5        5           
  Lines         123      123           
  Branches        1        1           
=======================================
  Hits           68       68           
  Misses         55       55           
Impacted Files Coverage Δ
src/main/scala/com/resy/ResyClient.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Alkaar Alkaar changed the title fix: increase timeout to avoid false negative fix: increase timeout to avoid false negatives Oct 1, 2022
@Alkaar Alkaar merged commit 4b8f0f3 into master Oct 1, 2022
@Alkaar Alkaar deleted the fix/increase-timeout-to-avoid-false-negative branch October 1, 2022 01:10
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

🚀 PR was released in v2.0.1 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Oct 1, 2022
@Alkaar Alkaar linked an issue Apr 2, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reservation booked but Bot says it was unsuccessful
2 participants