Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fail-safe when providing empty table type #86

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

Alkaar
Copy link
Owner

@Alkaar Alkaar commented Feb 14, 2023

Added a fail-safe so that providing an empty string table type is the same as not providing a table type at all. People have mistaken passing an empty string table type as not specifying a table type at all. This makes it such that the bot behaves the same way, preventing user error.

  • Empty string table type is the same as no table type
  • Added respective unit test

@Alkaar Alkaar added the feat A new feature label Feb 14, 2023
@Alkaar Alkaar self-assigned this Feb 14, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 58.62% // Head: 58.62% // No change to project coverage 👍

Coverage data is based on head (8a5571f) compared to base (a47c4f0).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   58.62%   58.62%           
=======================================
  Files           5        5           
  Lines         116      116           
  Branches        2        4    +2     
=======================================
  Hits           68       68           
  Misses         48       48           
Impacted Files Coverage Δ
src/main/scala/com/resy/ResyClient.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Alkaar Alkaar merged commit 6e693c9 into master Feb 14, 2023
@Alkaar Alkaar deleted the feat/support-empty-table-type branch February 14, 2023 13:46
@github-actions
Copy link

🚀 PR was released in v3.1.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat A new feature released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants