Added error event propagation for conversion. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like good news! But could anyone please explain in layman terms what I have to do to patch the original files (I'm on windows 10). The only "index.js" file I found is located in C:......\AppData\Local\Programs\AllToMP3\resources\app.asar.unpacked\node_modules\sharp\lib\index.js Upon inspection it looks like a completely different file. Replacing it predictably didn't work. My program version is 0.3.11.128 |
ghost
mentioned this pull request
|
I finally released a new version of the app (0.3.12), including this fix. |
|
You didn't do nothing, the problem still there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! When ffmpeg-fluent fails for some reason, the resulting error event won't get handled, and an error is thrown. I added an error handler so the download process won't halt as a consequence of this error.
This should almost fix AllToMP3/alltomp3-app#129: with the patch, only the error'd tracks will be skipped.