-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the aspect ratio issue #7
Conversation
Merge branch 'main' of https://github.com/teunbrand/geomtextpath into main # Conflicts: # R/grob_textpath.R
Excellent work Teun. This is the step that will make the whole project viable. I had been working today on trying to get I'll need to incorporate a few tweaks to fix the letter spacing again: you'll notice that the spacing changes a bit as the curvature varies in the spiral example. The apparent vjust also changes. These are just details though and I'm confident I can fix these quickly. I'm pretty excited with what we have after this. Nice to see the repo has been starred by some ggplot gurus (hrbrmstr and coolbutuseless). |
I'll also need to figure out why that text has flipped in the polar co-ordinates. Again, this looks like it should be a quick fix. I had a very similar bug on the spiral example to the one you showed. It's quite hypnotic really! |
This took a bit of refactoring but I believe I may have solved the pernicious aspect ratio - text angle issue as mentioned in #6 .
In brief:
textpathGrob()
constructor, which we can reuse in new geoms we've been ogling.Here is a charming picture from a bug I had at some point: