Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the aspect ratio issue #7

Merged
merged 25 commits into from
Nov 17, 2021
Merged

Fixing the aspect ratio issue #7

merged 25 commits into from
Nov 17, 2021

Commits on Nov 16, 2021

  1. Capture manipulations in a grob constructor.

    @teunbrand
    teunbrand committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    0bd54df View commit details
    Browse the repository at this point in the history

  2. Merge branch 'AllanCameron:main' into main

    @teunbrand
    teunbrand committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    7153df7 View commit details
    Browse the repository at this point in the history

  3. Adapt to shape_string

    @teunbrand
    teunbrand committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    e5aa449 View commit details
    Browse the repository at this point in the history

  4. Adapt to mm assumptions

    @teunbrand
    teunbrand committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    7ad105d View commit details
    Browse the repository at this point in the history

  5. Move tasks from ggproto to grob creation

    @teunbrand
    teunbrand committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    3effb08 View commit details
    Browse the repository at this point in the history

  6. Fix bug with static gpars

    @teunbrand
    teunbrand committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    fa56149 View commit details
    Browse the repository at this point in the history

  7. Stabilise default text gpar

    @teunbrand
    teunbrand committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    01428ba View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Stabilise default text gpar

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    a7a340c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'AllanCameron:main' into main

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    5bc7819 View commit details
    Browse the repository at this point in the history

  3. Sync with Allan's changes 

    Merge branch 'main' of https://github.com/teunbrand/geomtextpath into main

# Conflicts:
#	R/grob_textpath.R
    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    7a0d61e View commit details
    Browse the repository at this point in the history

  4. Move helper function to seperate file

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    ac08baf View commit details
    Browse the repository at this point in the history

  5. Document .add_path_data more formally.

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    6542727 View commit details
    Browse the repository at this point in the history

  6. Divorce vjust from data

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    a9849e5 View commit details
    Browse the repository at this point in the history

  7. Document .get_path_points() more formally.

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    3042fdd View commit details
    Browse the repository at this point in the history

  8. Divorce path from text in .get_path_points().

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    06ef390 View commit details
    Browse the repository at this point in the history

  9. Document .get_surrounding_lines() more formally.

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    366e5a9 View commit details
    Browse the repository at this point in the history

  10. Divorce vjust from text in .get_surrounding_lines().

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    8e3c479 View commit details
    Browse the repository at this point in the history

  11. Simplify textpathGrob().

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    69f71d3 View commit details
    Browse the repository at this point in the history

  12. Move responsibility for path identifiers.

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    707fbad View commit details
    Browse the repository at this point in the history

  13. Let makeContent method measure everything in inches rather than relat… 

    …ive units.
    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    1f7dd87 View commit details
    Browse the repository at this point in the history

  14. Convert text measurement to inches as well.

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    78fcbe3 View commit details
    Browse the repository at this point in the history

  15. Swap native to npc units (I don't trust native units)

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    81a6c39 View commit details
    Browse the repository at this point in the history

  16. Reflect changes in test

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    cb8b833 View commit details
    Browse the repository at this point in the history

  17. Remove mentions of the limitation that was lifted

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    2b0d6e6 View commit details
    Browse the repository at this point in the history

  18. Add news bullet and reoxygenate docs

    @teunbrand
    teunbrand committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    d4fbdbd View commit details
    Browse the repository at this point in the history