-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consequencer jan 24 #324
Consequencer jan 24 #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still yet to test the actual script so my comments are just limited to glancing at the README and the code but looks good so far!
If this has been tested with the most recent firmware i.e. including the recent PR merges, then I'm happy to merge |
In response to the testing comment. This has been tested with the latest firmware. However, I am unsure of the easiest way to find the recent PR merges you refer to. Any pointers? |
europi.py was updated in #328 and #326, I think that's the only one that's been changed that might affect this PR, and even then the changes might not affect it, but just good to check with the most recent files in the repo as opposed to the most recent release given how long ago the release was |
Thanks for the pointer. I have just tested with the latest EuroPi.py and
all functions seem to work well.
…On Tue, 6 Feb 2024, 12:43 Rory Allen, ***@***.***> wrote:
europi.py
In response to the testing comment. This has been tested with the latest
firmware. However, I am unsure of the easiest way to find the recent PR
merges you refer to. Any pointers?
europi.py was updated in #328
<#328> and #326
<#326>, I think that's the
only one that's been changed that might affect this PR, and even then the
changes might not affect it, but just good to check with the most recent
files in the repo as opposed to the most recent release given how long ago
the release was
—
Reply to this email directly, view it on GitHub
<#324 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKZSUKSGQUP5WTIOQ5HXUDYSIQOBAVCNFSM6AAAAABCQDKLPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRZGQ2DQNRWHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
reduced number of calls to update screen to improve performance for incoming clocks < 7ms
added grids patterns
added methods to reduce hysteresis on ain - this reduces the number of ain reads too
added methods to reduce hysteresis on k1 and k2 - this reduces the number of knob reads too
added screen saver to improve performance
changed the way the mode is displayed - replaced M1,M2,M3 with Mr,Mp,Mc for easier reading
cleaned up some code comments
added constants for easier code reading
updated documentation
applied black linting