Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consequencer jan 24 #324

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

gamecat69
Copy link
Contributor

reduced number of calls to update screen to improve performance for incoming clocks < 7ms
added grids patterns
added methods to reduce hysteresis on ain - this reduces the number of ain reads too
added methods to reduce hysteresis on k1 and k2 - this reduces the number of knob reads too
added screen saver to improve performance
changed the way the mode is displayed - replaced M1,M2,M3 with Mr,Mp,Mc for easier reading
cleaned up some code comments
added constants for easier code reading
updated documentation
applied black linting

Copy link
Collaborator

@roryjamesallen roryjamesallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still yet to test the actual script so my comments are just limited to glancing at the README and the code but looks good so far!

software/contrib/consequencer.md Outdated Show resolved Hide resolved
software/contrib/consequencer.md Outdated Show resolved Hide resolved
software/contrib/consequencer.py Show resolved Hide resolved
software/contrib/consequencer.py Show resolved Hide resolved
@roryjamesallen roryjamesallen added new script feature Feature additions or improvements to a contrib script suggestion New feature or request labels Feb 6, 2024
@roryjamesallen
Copy link
Collaborator

If this has been tested with the most recent firmware i.e. including the recent PR merges, then I'm happy to merge

@gamecat69
Copy link
Contributor Author

In response to the testing comment. This has been tested with the latest firmware. However, I am unsure of the easiest way to find the recent PR merges you refer to. Any pointers?

@roryjamesallen
Copy link
Collaborator

roryjamesallen commented Feb 6, 2024

In response to the testing comment. This has been tested with the latest firmware. However, I am unsure of the easiest way to find the recent PR merges you refer to. Any pointers?

europi.py was updated in #328 and #326, I think that's the only one that's been changed that might affect this PR, and even then the changes might not affect it, but just good to check with the most recent files in the repo as opposed to the most recent release given how long ago the release was

@gamecat69
Copy link
Contributor Author

gamecat69 commented Feb 6, 2024 via email

@roryjamesallen roryjamesallen merged commit 285056c into Allen-Synthesis:main Feb 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script feature Feature additions or improvements to a contrib script suggestion New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants